| Message ID | 1408421693-9929-2-git-send-email-Li.Xiubo@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Aug 19, 2014 at 12:14:49PM +0800, Xiubo Li wrote: > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> > --- > sound/soc/fsl/fsl_asrc.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c > index 8221104..3b14531 100644 > --- a/sound/soc/fsl/fsl_asrc.c > +++ b/sound/soc/fsl/fsl_asrc.c > @@ -802,10 +802,6 @@ static int fsl_asrc_probe(struct platform_device *pdev) > > asrc_priv->paddr = res->start; > > - /* Register regmap and let it prepare core clock */ > - if (of_property_read_bool(np, "big-endian")) > - fsl_asrc_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; > - What about the binding document? Could we also update that one since this 'big-endian' is useless? Thanks Nicolin
Hi, > Subject: Re: [PATCHv2 1/5] ASoC: fsl-asrc: Convert to use regmap framework's > endianness method. > > On Tue, Aug 19, 2014 at 12:14:49PM +0800, Xiubo Li wrote: > > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> > > --- > > sound/soc/fsl/fsl_asrc.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c > > index 8221104..3b14531 100644 > > --- a/sound/soc/fsl/fsl_asrc.c > > +++ b/sound/soc/fsl/fsl_asrc.c > > @@ -802,10 +802,6 @@ static int fsl_asrc_probe(struct platform_device *pdev) > > > > asrc_priv->paddr = res->start; > > > > - /* Register regmap and let it prepare core clock */ > > - if (of_property_read_bool(np, "big-endian")) > > - fsl_asrc_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; > > - > > What about the binding document? Could we also update that one > since this 'big-endian' is useless? > > Thanks > Nicolin No, the 'big-endian' is very useful still, deleting this because we are using The regmap framework's endianness method instead of its own here. And the binding document, as we have discussed days ago, no need to update here. Thanks, BRs Xiubo
On Mon, Aug 25, 2014 at 01:44:41AM +0000, Li.Xiubo@freescale.com wrote: > Hi, > > > Subject: Re: [PATCHv2 1/5] ASoC: fsl-asrc: Convert to use regmap framework's > > endianness method. > > > > On Tue, Aug 19, 2014 at 12:14:49PM +0800, Xiubo Li wrote: > > > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> > > > --- > > > sound/soc/fsl/fsl_asrc.c | 6 +----- > > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > > diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c > > > index 8221104..3b14531 100644 > > > --- a/sound/soc/fsl/fsl_asrc.c > > > +++ b/sound/soc/fsl/fsl_asrc.c > > > @@ -802,10 +802,6 @@ static int fsl_asrc_probe(struct platform_device *pdev) > > > > > > asrc_priv->paddr = res->start; > > > > > > - /* Register regmap and let it prepare core clock */ > > > - if (of_property_read_bool(np, "big-endian")) > > > - fsl_asrc_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; > > > - > > > > What about the binding document? Could we also update that one > > since this 'big-endian' is useless? > > > > Thanks > > Nicolin > > No, the 'big-endian' is very useful still, deleting this because we are using > The regmap framework's endianness method instead of its own here. > > And the binding document, as we have discussed days ago, no need to update here. Okay.. I think I've missed some topic here. Thanks, Nicolin
Hi Nicolin, > > > > diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c > > > > index 8221104..3b14531 100644 > > > > --- a/sound/soc/fsl/fsl_asrc.c > > > > +++ b/sound/soc/fsl/fsl_asrc.c > > > > @@ -802,10 +802,6 @@ static int fsl_asrc_probe(struct platform_device > *pdev) > > > > > > > > asrc_priv->paddr = res->start; > > > > > > > > - /* Register regmap and let it prepare core clock */ > > > > - if (of_property_read_bool(np, "big-endian")) > > > > - fsl_asrc_regmap_config.val_format_endian = > REGMAP_ENDIAN_BIG; > > > > - > > > > > > What about the binding document? Could we also update that one > > > since this 'big-endian' is useless? > > > > > > Thanks > > > Nicolin > > > > No, the 'big-endian' is very useful still, deleting this because we are > using > > The regmap framework's endianness method instead of its own here. > > > > And the binding document, as we have discussed days ago, no need to update > here. > > Okay.. I think I've missed some topic here. > Please refer to the following patches about this: regmap: add DT endianness binding support. regmap: Add the DT binding documentation for endianness And also two of other patches to fix some bugs of these. Thanks, BRs Xiubo
On Mon, Aug 25, 2014 at 02:29:32AM +0000, Li.Xiubo@freescale.com wrote: > > > No, the 'big-endian' is very useful still, deleting this because we are > > using > > > The regmap framework's endianness method instead of its own here. > > > > > > And the binding document, as we have discussed days ago, no need to update > > here. > > > > Okay.. I think I've missed some topic here. > > > > Please refer to the following patches about this: > > regmap: add DT endianness binding support. > regmap: Add the DT binding documentation for endianness > And also two of other patches to fix some bugs of these. > Great. Thank you :)
diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 8221104..3b14531 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c @@ -684,7 +684,7 @@ static bool fsl_asrc_writeable_reg(struct device *dev, unsigned int reg) } } -static struct regmap_config fsl_asrc_regmap_config = { +static const struct regmap_config fsl_asrc_regmap_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, @@ -802,10 +802,6 @@ static int fsl_asrc_probe(struct platform_device *pdev) asrc_priv->paddr = res->start; - /* Register regmap and let it prepare core clock */ - if (of_property_read_bool(np, "big-endian")) - fsl_asrc_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; - asrc_priv->regmap = devm_regmap_init_mmio_clk(&pdev->dev, "mem", regs, &fsl_asrc_regmap_config); if (IS_ERR(asrc_priv->regmap)) {
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> --- sound/soc/fsl/fsl_asrc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)