| Message ID | 1409219720.21395.5.camel@phoenix (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a4f87cea72d78f80c0bda1b4d8a821278eb1e4e2 |
| Headers | show |
On Thu, 28 Aug 2014, Axel Lin wrote: > The regulator_bulk_free() call is not required because current code is using > devm_regulator_bulk_get(). > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > sound/soc/codecs/cs42l56.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c > index c766a5a..5a2d732 100644 > --- a/sound/soc/codecs/cs42l56.c > +++ b/sound/soc/codecs/cs42l56.c > @@ -1175,11 +1175,8 @@ static int cs42l56_probe(struct snd_soc_codec *codec) > > static int cs42l56_remove(struct snd_soc_codec *codec) > { > - struct cs42l56_private *cs42l56 = snd_soc_codec_get_drvdata(codec); > - > cs42l56_free_beep(codec); > cs42l56_set_bias_level(codec, SND_SOC_BIAS_OFF); > - regulator_bulk_free(ARRAY_SIZE(cs42l56->supplies), cs42l56->supplies); > > return 0; > } Thanks Axel, For the series.. Acked-by: Brian Austin <brian.austin@cirrus.com>
diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c index c766a5a..5a2d732 100644 --- a/sound/soc/codecs/cs42l56.c +++ b/sound/soc/codecs/cs42l56.c @@ -1175,11 +1175,8 @@ static int cs42l56_probe(struct snd_soc_codec *codec) static int cs42l56_remove(struct snd_soc_codec *codec) { - struct cs42l56_private *cs42l56 = snd_soc_codec_get_drvdata(codec); - cs42l56_free_beep(codec); cs42l56_set_bias_level(codec, SND_SOC_BIAS_OFF); - regulator_bulk_free(ARRAY_SIZE(cs42l56->supplies), cs42l56->supplies); return 0; }
The regulator_bulk_free() call is not required because current code is using devm_regulator_bulk_get(). Signed-off-by: Axel Lin <axel.lin@ingics.com> --- sound/soc/codecs/cs42l56.c | 3 --- 1 file changed, 3 deletions(-)