diff mbox

ALSA: hda - add explicit include of err.h

Message ID 1411455890-8324-1-git-send-email-david.henningsson@canonical.com (mailing list archive)
State Accepted
Commit a5062dee82826f54529c89d0e58211897b1b4c68
Delegated to: Takashi Iwai
Headers show

Commit Message

David Henningsson Sept. 23, 2014, 7:04 a.m. UTC 
Since every caller of snd_hda_jack_detect_enable_callback needs to
use the macros from err.h, it makes sense to include it directly
from hda_jack.h.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/hda_jack.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Takashi Iwai Sept. 23, 2014, 7:46 a.m. UTC | #1 
At Tue, 23 Sep 2014 09:04:49 +0200,
David Henningsson wrote:
> 
> Since every caller of snd_hda_jack_detect_enable_callback needs to
> use the macros from err.h, it makes sense to include it directly
> from hda_jack.h.
> 
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>

Thanks, applied (both).


Takashi

> ---
>  sound/pci/hda/hda_jack.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/hda_jack.h b/sound/pci/hda/hda_jack.h
> index b41e0a3..13cb375 100644
> --- a/sound/pci/hda/hda_jack.h
> +++ b/sound/pci/hda/hda_jack.h
> @@ -12,6 +12,8 @@
>  #ifndef __SOUND_HDA_JACK_H
>  #define __SOUND_HDA_JACK_H
>  
> +#include <linux/err.h>
> +
>  struct auto_pin_cfg;
>  struct hda_jack_tbl;
>  struct hda_jack_callback;
> -- 
> 1.9.1
>
diff mbox

Patch

diff --git a/sound/pci/hda/hda_jack.h b/sound/pci/hda/hda_jack.h
index b41e0a3..13cb375 100644
--- a/sound/pci/hda/hda_jack.h
+++ b/sound/pci/hda/hda_jack.h
@@ -12,6 +12,8 @@ 
 #ifndef __SOUND_HDA_JACK_H
 #define __SOUND_HDA_JACK_H
 
+#include <linux/err.h>
+
 struct auto_pin_cfg;
 struct hda_jack_tbl;
 struct hda_jack_callback;