| Message ID | 1411896577-30965-1-git-send-email-Li.Xiubo@freescale.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6596aa047b624aeec2ea321962cfdecf9953a383 |
| Headers | show |
On Sun, Sep 28, 2014 at 05:29:37PM +0800, Xiubo Li wrote: > Since we cannot make sure the 'params->num_regs' will always be none > zero here, and then if it equals to zero, the kmemdup() will return > ZERO_SIZE_PTR, which equals to ((void *)16). Applied, thanks.
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 7b5a7ce..263514a 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -3051,7 +3051,7 @@ int snd_soc_bytes_put(struct snd_kcontrol *kcontrol, unsigned int val, mask; void *data; - if (!component->regmap) + if (!component->regmap || !params->num_regs) return -EINVAL; len = params->num_regs * component->val_bytes;
Since we cannot make sure the 'params->num_regs' will always be none zero here, and then if it equals to zero, the kmemdup() will return ZERO_SIZE_PTR, which equals to ((void *)16). So this patch fix this with just doing the zero check before calling kmemdup(). Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> --- sound/soc/soc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)