diff mbox

[1/4] ASoC: mc13783: Delete unneeded test before of_node_put

Message ID 1412706598-18796-1-git-send-email-fabio.estevam@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam Oct. 7, 2014, 6:29 p.m. UTC 
of_node_put() supports NULL as its argument, so the initial test is not
necessary.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 sound/soc/codecs/mc13783.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Mark Brown Oct. 7, 2014, 6:59 p.m. UTC | #1 
On Tue, Oct 07, 2014 at 03:29:55PM -0300, Fabio Estevam wrote:

>  out:
> -	if (np)
> -		of_node_put(np);
> +	of_node_put(np);

This doesn't apply against current code, there's no np check?
diff mbox

Patch

diff --git a/sound/soc/codecs/mc13783.c b/sound/soc/codecs/mc13783.c
index 2c1f1b0..388f90a 100644
--- a/sound/soc/codecs/mc13783.c
+++ b/sound/soc/codecs/mc13783.c
@@ -784,8 +784,7 @@  static int __init mc13783_codec_probe(struct platform_device *pdev)
 			mc13783_dai_async, ARRAY_SIZE(mc13783_dai_async));
 
 out:
-	if (np)
-		of_node_put(np);
+	of_node_put(np);
 	return ret;
 }