| Message ID | 1414910081-2487-1-git-send-email-sudipm.mukherjee@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 22a236b4d07b5c5cfdc5db9e87d479d32281cfe6 |
| Headers | show |
On Sun, Nov 02, 2014 at 12:04:41PM +0530, Sudip Mukherjee wrote: > on error in block prepare, we were returning the error code while still > holding the mutex. We are releasing the mutex in this patch before > return. Applied, thanks.
diff --git a/sound/soc/intel/sst-firmware.c b/sound/soc/intel/sst-firmware.c index 35788ad..dca6d9a 100644 --- a/sound/soc/intel/sst-firmware.c +++ b/sound/soc/intel/sst-firmware.c @@ -1120,6 +1120,7 @@ int sst_block_alloc_scratch(struct sst_dsp *dsp) ret = block_list_prepare(dsp, &dsp->scratch_block_list); if (ret < 0) { dev_err(dsp->dev, "error: scratch block prepare failed\n"); + mutex_unlock(&dsp->mutex); return ret; }
on error in block prepare, we were returning the error code while still holding the mutex. We are releasing the mutex in this patch before return. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- sound/soc/intel/sst-firmware.c | 1 + 1 file changed, 1 insertion(+)