From patchwork Fri Nov 14 10:39:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 5304791 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2E61A9F2ED for ; Fri, 14 Nov 2014 10:40:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 60CAE201BC for ; Fri, 14 Nov 2014 10:40:09 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id B97FE2015D for ; Fri, 14 Nov 2014 10:40:07 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 26EE22665C4; Fri, 14 Nov 2014 11:40:06 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NO_DNS_FOR_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 2847E2605BE; Fri, 14 Nov 2014 11:39:31 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 71D5C26657A; Fri, 14 Nov 2014 11:39:29 +0100 (CET) Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by alsa0.perex.cz (Postfix) with ESMTP id 85DC8260542 for ; Fri, 14 Nov 2014 11:39:21 +0100 (CET) Received: by mail-pa0-f53.google.com with SMTP id kx10so17306087pab.12 for ; Fri, 14 Nov 2014 02:39:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=e6R9UiPu5oE80Wgbd7aqsTSi9JONeS2n394Y6N/HN6E=; b=CX2SvLD6rNMHWV2eEkuyYIRmC+917QLlF/HGUup3tEM15u7tcLRS8RREj1/cjdsk58 7oJmXCOMMYWvXvSzEDqOg9kVyluN9liL+GK5Ky2crryhfvZG5lPpmIOmZs96OTOZEbwl w+ydbfwIIFeY2SZPyHa9azL61qx3sK7GdBcYAJRvXNAlueQ2vrAiD3QUYNx3E2JcgSxS 6YPDEXctMhTvJhpxQbU8pV98SvzQdH3/CQ8W+8eK8QgG2G9wNlzKxEVI6pnmZ13y4TWO BRdJ+j8MUGN9BdSMnm34O5wozqGudMC/iUjQXerys8WsLwlAWg7eEcmemMdJ7NwfIPZV Ho2w== X-Received: by 10.69.25.73 with SMTP id io9mr9316183pbd.90.1415961560018; Fri, 14 Nov 2014 02:39:20 -0800 (PST) Received: from localhost.localdomain ([122.169.164.56]) by mx.google.com with ESMTPSA id v4sm926085pbs.10.2014.11.14.02.39.17 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Nov 2014 02:39:19 -0800 (PST) From: Sudip Mukherjee To: Takashi Iwai Date: Fri, 14 Nov 2014 16:09:06 +0530 Message-Id: <1415961547-10330-2-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1415961547-10330-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1415961547-10330-1-git-send-email-sudipm.mukherjee@gmail.com> Cc: alsa-devel@alsa-project.org, Sudip Mukherjee , linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH v2 2/3] ALSA: ice1712: consider error value X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP earlier we were ignoring the return value of snd_ak4114_create and always returning 0. now we are returning the actual status. revo_init is calling this function, and revo_init is checking the return value. Signed-off-by: Sudip Mukherjee --- sound/pci/ice1712/revo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/ice1712/revo.c b/sound/pci/ice1712/revo.c index 1112ec1..2835196 100644 --- a/sound/pci/ice1712/revo.c +++ b/sound/pci/ice1712/revo.c @@ -498,7 +498,7 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice) * No reason to stop capture stream due to incorrect checks */ spec->ak4114->check_flags = AK4114_CHECK_NO_RATE; - return 0; /* error ignored; it's no fatal error */ + return err; } static int revo_init(struct snd_ice1712 *ice)