| Message ID | 1418913635-7422-1-git-send-email-jarkko.nikula@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | da042e3a6261a444868b99bece98e4e5b77a0fce |
| Headers | show |
On 12/18/14 06:40, Jarkko Nikula wrote: > Fix following build error when CONFIG_I2C is not enabled: > > sound/soc/codecs/rt5640.c:2252:1: warning: data definition has no type or storage class > module_i2c_driver(rt5640_i2c_driver); > ^ > sound/soc/codecs/rt5640.c:2252:1: error: type defaults to ‘int’ in declaration of ‘module_i2c_driver’ [-Werror=implicit-int] > sound/soc/codecs/rt5640.c:2252:1: warning: parameter names (without types) in function declaration > sound/soc/codecs/rt5640.c:2241:26: warning: ‘rt5640_i2c_driver’ defined but not used [-Wunused-variable] > static struct i2c_driver rt5640_i2c_driver = { > ^ > cc1: some warnings being treated as errors > > Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > Reported-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > Cc: Subhransu S. Prusty <subhransu.s.prusty@intel.com> > Cc: Mengdong Lin <mengdong.lin@intel.com> > --- > sound/soc/intel/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig > index e989ecf046c9..f86de1211b96 100644 > --- a/sound/soc/intel/Kconfig > +++ b/sound/soc/intel/Kconfig > @@ -89,7 +89,7 @@ config SND_SOC_INTEL_BROADWELL_MACH > > config SND_SOC_INTEL_BYTCR_RT5640_MACH > tristate "ASoC Audio DSP Support for MID BYT Platform" > - depends on X86 > + depends on X86 && I2C > select SND_SOC_RT5640 > select SND_SST_MFLD_PLATFORM > select SND_SST_IPC_ACPI > @@ -101,7 +101,7 @@ config SND_SOC_INTEL_BYTCR_RT5640_MACH > > config SND_SOC_INTEL_CHT_BSW_RT5672_MACH > tristate "ASoC Audio driver for Intel Cherrytrail & Braswell with RT5672 codec" > - depends on X86_INTEL_LPSS > + depends on X86_INTEL_LPSS && I2C > select SND_SOC_RT5670 > select SND_SST_MFLD_PLATFORM > select SND_SST_IPC_ACPI >
On Thu, Dec 18, 2014 at 04:40:35PM +0200, Jarkko Nikula wrote:
> Fix following build error when CONFIG_I2C is not enabled:
Applied, thanks.
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index e989ecf046c9..f86de1211b96 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc/intel/Kconfig @@ -89,7 +89,7 @@ config SND_SOC_INTEL_BROADWELL_MACH config SND_SOC_INTEL_BYTCR_RT5640_MACH tristate "ASoC Audio DSP Support for MID BYT Platform" - depends on X86 + depends on X86 && I2C select SND_SOC_RT5640 select SND_SST_MFLD_PLATFORM select SND_SST_IPC_ACPI @@ -101,7 +101,7 @@ config SND_SOC_INTEL_BYTCR_RT5640_MACH config SND_SOC_INTEL_CHT_BSW_RT5672_MACH tristate "ASoC Audio driver for Intel Cherrytrail & Braswell with RT5672 codec" - depends on X86_INTEL_LPSS + depends on X86_INTEL_LPSS && I2C select SND_SOC_RT5670 select SND_SST_MFLD_PLATFORM select SND_SST_IPC_ACPI
Fix following build error when CONFIG_I2C is not enabled: sound/soc/codecs/rt5640.c:2252:1: warning: data definition has no type or storage class module_i2c_driver(rt5640_i2c_driver); ^ sound/soc/codecs/rt5640.c:2252:1: error: type defaults to ‘int’ in declaration of ‘module_i2c_driver’ [-Werror=implicit-int] sound/soc/codecs/rt5640.c:2252:1: warning: parameter names (without types) in function declaration sound/soc/codecs/rt5640.c:2241:26: warning: ‘rt5640_i2c_driver’ defined but not used [-Wunused-variable] static struct i2c_driver rt5640_i2c_driver = { ^ cc1: some warnings being treated as errors Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Reported-by: Randy Dunlap <rdunlap@infradead.org> Cc: Subhransu S. Prusty <subhransu.s.prusty@intel.com> Cc: Mengdong Lin <mengdong.lin@intel.com> --- sound/soc/intel/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)