diff mbox

sound: soc: atmel sam9g20_wm8731: remove useless include

Message ID 1420536080-29181-1-git-send-email-alexandre.belloni@free-electrons.com (mailing list archive)
State Accepted
Commit 7491831f4f034e2d76326518145da9525dd90932
Headers show

Commit Message

Alexandre Belloni Jan. 6, 2015, 9:21 a.m. UTC 
A mach/ header is included but never used. Simply remove it.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 sound/soc/atmel/sam9g20_wm8731.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Bo Shen Jan. 6, 2015, 10:14 a.m. UTC | #1 
Hi Alexandre Belloni,

On 01/06/2015 05:21 PM, Alexandre Belloni wrote:
> A mach/ header is included but never used. Simply remove it.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Thanks for your patch.

Acked-by: Bo Shen <voice.shen@atmel.com>

> ---
>   sound/soc/atmel/sam9g20_wm8731.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index 66b66d0e7514..531728975bbb 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -47,7 +47,6 @@
>   #include <sound/soc.h>
>
>   #include <asm/mach-types.h>

Btw, do you consider to remove this also?

> -#include <mach/hardware.h>
>
>   #include "../codecs/wm8731.h"
>   #include "atmel-pcm.h"
>

Best Regards,
Bo Shen
Alexandre Belloni Jan. 6, 2015, 11:15 a.m. UTC | #2 
Hi Bo,

On 06/01/2015 at 18:14:12 +0800, Bo Shen wrote :
> >
> >  #include <asm/mach-types.h>
> 
> Btw, do you consider to remove this also?
> 

I just sent a patch for that. Feel free to squash both.

> >-#include <mach/hardware.h>
> >
> >  #include "../codecs/wm8731.h"
> >  #include "atmel-pcm.h"
> >
Mark Brown Jan. 6, 2015, 5:45 p.m. UTC | #3 
On Tue, Jan 06, 2015 at 10:21:20AM +0100, Alexandre Belloni wrote:
> A mach/ header is included but never used. Simply remove it.

Applied, like I say please do use subject lines matching the style for
the subsystem.
diff mbox

Patch

diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
index 66b66d0e7514..531728975bbb 100644
--- a/sound/soc/atmel/sam9g20_wm8731.c
+++ b/sound/soc/atmel/sam9g20_wm8731.c
@@ -47,7 +47,6 @@ 
 #include <sound/soc.h>
 
 #include <asm/mach-types.h>
-#include <mach/hardware.h>
 
 #include "../codecs/wm8731.h"
 #include "atmel-pcm.h"