diff mbox

ALSA: control: fix failure to return new numerical ID in 'replace' event data

Message ID 1423494105-24001-1-git-send-email-o-takashi@sakamocchi.jp (mailing list archive)
State New, archived
Headers show

Commit Message

Takashi Sakamoto Feb. 9, 2015, 3:01 p.m. UTC
In 'replace' event data, numerical ID of control is always invalid. This
commit fix this bug so as the event data has renewed numerical ID for
control.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/core/control.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Takashi Iwai Feb. 9, 2015, 3:34 p.m. UTC | #1
At Tue, 10 Feb 2015 00:01:45 +0900,
Takashi Sakamoto wrote:
> 
> In 'replace' event data, numerical ID of control is always invalid. This
> commit fix this bug so as the event data has renewed numerical ID for
> control.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Applied, thanks.


Takashi

> ---
>  sound/core/control.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/core/control.c b/sound/core/control.c
> index 884fddd..ab74b7e 100644
> --- a/sound/core/control.c
> +++ b/sound/core/control.c
> @@ -440,6 +440,7 @@ add:
>  	card->controls_count += kcontrol->count;
>  	kcontrol->id.numid = card->last_numid + 1;
>  	card->last_numid += kcontrol->count;
> +	id = kcontrol->id;
>  	count = kcontrol->count;
>  	up_write(&card->controls_rwsem);
>  	for (idx = 0; idx < count; idx++, id.index++, id.numid++)
> -- 
> 2.1.0
>
diff mbox

Patch

diff --git a/sound/core/control.c b/sound/core/control.c
index 884fddd..ab74b7e 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -440,6 +440,7 @@  add:
 	card->controls_count += kcontrol->count;
 	kcontrol->id.numid = card->last_numid + 1;
 	card->last_numid += kcontrol->count;
+	id = kcontrol->id;
 	count = kcontrol->count;
 	up_write(&card->controls_rwsem);
 	for (idx = 0; idx < count; idx++, id.index++, id.numid++)