diff mbox

[2/2] ASoC: Intel: Remove vague commit about slave DMA config from firmware loader

Message ID 1426666040-1727-2-git-send-email-jarkko.nikula@linux.intel.com (mailing list archive)
State Accepted
Commit 91b0d9aa933a2335f6f11983b19eaf9ebe3c2033
Headers show

Commit Message

Jarkko Nikula March 18, 2015, 8:07 a.m. UTC
Intel MID DMA driver is going to be removed, commit should be a few lines
down near to dmaengine_slave_config() call in order to not confuse and at
quick look Synopsys DesignWare does seem to use some of the slave config
structure fields (see drivers/dma/dw/core.c: dwc_config()).

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
 sound/soc/intel/sst-firmware.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Mark Brown March 18, 2015, 11:44 a.m. UTC | #1
On Wed, Mar 18, 2015 at 10:07:20AM +0200, Jarkko Nikula wrote:
> Intel MID DMA driver is going to be removed, commit should be a few lines
> down near to dmaengine_slave_config() call in order to not confuse and at
> quick look Synopsys DesignWare does seem to use some of the slave config
> structure fields (see drivers/dma/dw/core.c: dwc_config()).

Applied both, thanks.
diff mbox

Patch

diff --git a/sound/soc/intel/sst-firmware.c b/sound/soc/intel/sst-firmware.c
index 38881f1fb990..b5659ecb80de 100644
--- a/sound/soc/intel/sst-firmware.c
+++ b/sound/soc/intel/sst-firmware.c
@@ -221,8 +221,6 @@  int sst_dsp_dma_get_channel(struct sst_dsp *dsp, int chan_id)
 	dma_cap_mask_t mask;
 	int ret;
 
-	/* The Intel MID DMA engine driver needs the slave config set but
-	 * Synopsis DMA engine driver safely ignores the slave config */
 	dma_cap_zero(mask);
 	dma_cap_set(DMA_SLAVE, mask);
 	dma_cap_set(DMA_MEMCPY, mask);