diff mbox

ASoC: davinci-evm: drop un-necessary remove function

Message ID 1427377105-29044-1-git-send-email-jsarha@ti.com (mailing list archive)
State Accepted
Commit a57069e33fbc6625f39e1b09c88ea44629a35206
Headers show

Commit Message

Jyri Sarha March 26, 2015, 1:38 p.m. UTC 
From: Manish Badarkhe <manishvb@ti.com>

As davinci card gets registered using 'devm_' api
there is no need to unregister the card in 'remove'
function.
Hence drop the 'remove' function.

Signed-off-by: Manish Badarkhe <manishvb@ti.com>
Signed-off-by: Jyri Sarha <jsarha@ti.com>
---
 sound/soc/davinci/davinci-evm.c | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Mark Brown March 26, 2015, 5:02 p.m. UTC | #1 
On Thu, Mar 26, 2015 at 03:38:25PM +0200, Jyri Sarha wrote:
> From: Manish Badarkhe <manishvb@ti.com>
> 
> As davinci card gets registered using 'devm_' api
> there is no need to unregister the card in 'remove'
> function.
> Hence drop the 'remove' function.

Not only that but the current remove function creates a double free.
Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/davinci/davinci-evm.c b/sound/soc/davinci/davinci-evm.c
index b6bb594..8c2b9be 100644
--- a/sound/soc/davinci/davinci-evm.c
+++ b/sound/soc/davinci/davinci-evm.c
@@ -425,18 +425,8 @@  static int davinci_evm_probe(struct platform_device *pdev)
 	return ret;
 }
 
-static int davinci_evm_remove(struct platform_device *pdev)
-{
-	struct snd_soc_card *card = platform_get_drvdata(pdev);
-
-	snd_soc_unregister_card(card);
-
-	return 0;
-}
-
 static struct platform_driver davinci_evm_driver = {
 	.probe		= davinci_evm_probe,
-	.remove		= davinci_evm_remove,
 	.driver		= {
 		.name	= "davinci_evm",
 		.pm	= &snd_soc_pm_ops,