| Message ID | 1427909757-19483-1-git-send-email-jsarha@ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7b425f264fc2572bea8b15fe97948659507c6a45 |
| Headers | show |
On Wed, Apr 01, 2015 at 08:35:57PM +0300, Jyri Sarha wrote: > No IEC958_AES?_PRO_* macros should be used in HDMI consumer audio mode > and IEC958_AES1_PRO_MODE_NOTID should be applied to byte 1 when > applicable. However IEC958_AES1_PRO_MODE_NOTID is defined as 0 so this > fix does not affect the functionality in any way. Applied, thanks.
diff --git a/sound/soc/omap/omap-hdmi-audio.c b/sound/soc/omap/omap-hdmi-audio.c index f7eb42a..4775da4 100644 --- a/sound/soc/omap/omap-hdmi-audio.c +++ b/sound/soc/omap/omap-hdmi-audio.c @@ -142,8 +142,6 @@ static int hdmi_dai_hw_params(struct snd_pcm_substream *substream, iec->status[0] |= IEC958_AES0_CON_EMPHASIS_NONE; - iec->status[0] |= IEC958_AES1_PRO_MODE_NOTID; - iec->status[1] = IEC958_AES1_CON_GENERAL; iec->status[2] |= IEC958_AES2_CON_SOURCE_UNSPEC;
No IEC958_AES?_PRO_* macros should be used in HDMI consumer audio mode and IEC958_AES1_PRO_MODE_NOTID should be applied to byte 1 when applicable. However IEC958_AES1_PRO_MODE_NOTID is defined as 0 so this fix does not affect the functionality in any way. Reported-by: Russell King <linux@arm.linux.org.uk> Signed-off-by: Jyri Sarha <jsarha@ti.com> --- When I refactored the OMAP HDMI audio functionality I intentionally wanted to keep all the HW bits identical to the earlier implementation so that I could compare the register values of the old and the new implementations one to one. One of these days I should go trough and check all the bits now that new implementation has settled in. Best regards, Jyri sound/soc/omap/omap-hdmi-audio.c | 2 -- 1 file changed, 2 deletions(-)