From patchwork Tue Apr 21 04:19:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 6245551 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3A834BF4A6 for ; Tue, 21 Apr 2015 04:20:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 56CEE2024F for ; Tue, 21 Apr 2015 04:20:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id EEF6A20173 for ; Tue, 21 Apr 2015 04:20:13 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id A4280265E0B; Tue, 21 Apr 2015 06:20:12 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id A7DF9260815; Tue, 21 Apr 2015 06:20:04 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 3A76B265DE6; Tue, 21 Apr 2015 06:20:03 +0200 (CEST) Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by alsa0.perex.cz (Postfix) with ESMTP id EBDC32606C9 for ; Tue, 21 Apr 2015 06:19:55 +0200 (CEST) Received: by paboj16 with SMTP id oj16so228572097pab.0 for ; Mon, 20 Apr 2015 21:19:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=255tKtVhOwRsrA2hAZno2ZCGZD9o++ez/vEcMOQYVng=; b=Veshdsjt2TPTLu4k8IcSvwoZqLafen6Auo+hMfaTSAhiQuEJ2tjDRSnvQMS0MhA/z1 o5EIB6iy4AcrzUzulfXWXZ0O8/CXgNkCKmSGEt7kt8kEAw4hp8Y56+F+1q6YtWwUf3i2 C7nmFImZGKHAidVnqMpVNZv8R5+XrdlhNz7MYzi/VH5XilUpX99COBzJD7j6PyvqUvBz NqSq5WZnozNaMQmTUE1OrYIhwLyvsgowDsASXyILWnhgDwiB+leybebk6pRTvq0LLLSJ ADujSc0229thwphZjyA7e/oeC0C9ZbPBXhj3A9l+mzw3+t4uPyvxebv65NcViHLZ2NSn X3bQ== X-Gm-Message-State: ALoCoQnFdLVX5oJbQdL5wLKql82PGur2nwAFNgET/SD6l+tDc3m0eGQdYTG3BWuniZFs8yu4vSE5 X-Received: by 10.68.218.103 with SMTP id pf7mr24488032pbc.32.1429589994868; Mon, 20 Apr 2015 21:19:54 -0700 (PDT) Received: from phoenix.local (218-164-101-26.dynamic.hinet.net. [218.164.101.26]) by mx.google.com with ESMTPSA id ry2sm481146pbb.83.2015.04.20.21.19.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Apr 2015 21:19:53 -0700 (PDT) Message-ID: <1429589989.12465.1.camel@ingics.com> From: Axel Lin To: Mark Brown Date: Tue, 21 Apr 2015 12:19:49 +0800 X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Cc: Oder Chiou , Bard Liao , "alsa-devel@alsa-project.org" , Liam Girdwood Subject: [alsa-devel] [PATCH RFT] ASoC: rt5645: Fix mask for setting RT5645_DMIC_2_DP_GPIO12 bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Current code uses wrong mask when setting RT5645_DMIC_2_DP_GPIO12 bit, fix it. Signed-off-by: Axel Lin --- Hi Bard, I don't have the h/w to test, so please review and test this patch. Thanks, Axel sound/soc/codecs/rt5645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 69528ae..a249f65 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -2770,7 +2770,7 @@ static int rt5645_i2c_probe(struct i2c_client *i2c, case RT5645_DMIC_DATA_GPIO12: regmap_update_bits(rt5645->regmap, RT5645_DMIC_CTRL1, - RT5645_DMIC_1_DP_MASK, RT5645_DMIC_2_DP_GPIO12); + RT5645_DMIC_2_DP_MASK, RT5645_DMIC_2_DP_GPIO12); regmap_update_bits(rt5645->regmap, RT5645_GPIO_CTRL1, RT5645_GP12_PIN_MASK, RT5645_GP12_PIN_DMIC2_SDA);