| Message ID | 1430117495.28082.2.camel@ingics.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 545774bd6e1427d98dde77244329d2311c5eca6f |
| Headers | show |
Hello, Le 27. 04. 15 08:51, Axel Lin a écrit : > mc13xxx_reg_rmw() won't change any bit if passing 0 to the mask field. > Pass AUDIO_SSI_SEL instead of 0 for the mask field to set AUDIO_SSI_SEL > bit. > I'm sorry but I don't have access to the hardware anymore. Maybe Fabio Estevam or Shawn Guo can test it. Regards, Philippe
On Mon, Apr 27, 2015 at 02:51:35PM +0800, Axel Lin wrote: > mc13xxx_reg_rmw() won't change any bit if passing 0 to the mask field. > Pass AUDIO_SSI_SEL instead of 0 for the mask field to set AUDIO_SSI_SEL > bit. Applied, thanks.
diff --git a/sound/soc/codecs/mc13783.c b/sound/soc/codecs/mc13783.c index 2ffb9a0..3d44fc5 100644 --- a/sound/soc/codecs/mc13783.c +++ b/sound/soc/codecs/mc13783.c @@ -623,14 +623,14 @@ static int mc13783_probe(struct snd_soc_codec *codec) AUDIO_SSI_SEL, 0); else mc13xxx_reg_rmw(priv->mc13xxx, MC13783_AUDIO_CODEC, - 0, AUDIO_SSI_SEL); + AUDIO_SSI_SEL, AUDIO_SSI_SEL); if (priv->dac_ssi_port == MC13783_SSI1_PORT) mc13xxx_reg_rmw(priv->mc13xxx, MC13783_AUDIO_DAC, AUDIO_SSI_SEL, 0); else mc13xxx_reg_rmw(priv->mc13xxx, MC13783_AUDIO_DAC, - 0, AUDIO_SSI_SEL); + AUDIO_SSI_SEL, AUDIO_SSI_SEL); return 0; }
mc13xxx_reg_rmw() won't change any bit if passing 0 to the mask field. Pass AUDIO_SSI_SEL instead of 0 for the mask field to set AUDIO_SSI_SEL bit. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- Hi, I don't have this h/w for test, so please help review and test this patch. Thanks. sound/soc/codecs/mc13783.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)