From patchwork Mon Apr 27 06:51:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 6278311 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8339A9F6E1 for ; Mon, 27 Apr 2015 06:52:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B46822041C for ; Mon, 27 Apr 2015 06:52:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 9E3E82041D for ; Mon, 27 Apr 2015 06:52:05 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7D43A261B33; Mon, 27 Apr 2015 08:51:59 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id EFEAB260538; Mon, 27 Apr 2015 08:51:51 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 1463D260563; Mon, 27 Apr 2015 08:51:50 +0200 (CEST) Received: from mail-pd0-f180.google.com (mail-pd0-f180.google.com [209.85.192.180]) by alsa0.perex.cz (Postfix) with ESMTP id B5D7A260537 for ; Mon, 27 Apr 2015 08:51:42 +0200 (CEST) Received: by pdea3 with SMTP id a3so118658024pde.3 for ; Sun, 26 Apr 2015 23:51:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=/pC8+pvTg6DC+diQ83pXqP41Kle0mrCN4+R0Ff+gzS8=; b=VHh3gjwGqovQiUSXGHWReXpoLdCAk2zG2JOW2NDPv7GyN/IguapRuHmY+r0GS3Af7e MvHIDXuGxEeZHY3uEIHS8MMohdsm3Q21jfjvVaIa/v2kJ2DgCnqN1xlRJ3oeIn8MXQP1 ibe/duSL4cb4nK4ST8UrA3n/uVNDknQXfcbJISSpLBCgtPjTZyhDnB1Bjv6wYx0IxgK7 VMNXCBacAsh8AsvHQUDFrapcJbqAlTDQxAeOETktZsybusqCjrRuHF9BoTAaecmjfb1b z7bq0u/HrL4H2sA/YqlTEg9XiBeBqY7emK/pM/Zh9UtBsocgnb7PCUJsPjqNveuAVdsh +uiA== X-Gm-Message-State: ALoCoQl/KkvQHNNVPZf3jeqNLKQqEB4uhcV1Fk2BX14Y1RC43Z+6COO1r3w7U+TRGJg5Xe8qib/A X-Received: by 10.68.65.111 with SMTP id w15mr19506823pbs.57.1430117501025; Sun, 26 Apr 2015 23:51:41 -0700 (PDT) Received: from phoenix (36-229-223-41.dynamic-ip.hinet.net. [36.229.223.41]) by mx.google.com with ESMTPSA id f4sm18215060pdc.95.2015.04.26.23.51.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Apr 2015 23:51:39 -0700 (PDT) Message-ID: <1430117495.28082.2.camel@ingics.com> From: Axel Lin To: Mark Brown Date: Mon, 27 Apr 2015 14:51:35 +0800 X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Cc: Philippe =?ISO-8859-1?Q?R=E9tornaz?= , SaschaHauer , Steffen Trumtrar , Liam Girdwood , "alsa-devel@alsa-project.org" Subject: [alsa-devel] [PATCH RFT] ASoC: mc13783: Fix wrong mask value used in mc13xxx_reg_rmw() calls X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP mc13xxx_reg_rmw() won't change any bit if passing 0 to the mask field. Pass AUDIO_SSI_SEL instead of 0 for the mask field to set AUDIO_SSI_SEL bit. Signed-off-by: Axel Lin --- Hi, I don't have this h/w for test, so please help review and test this patch. Thanks. sound/soc/codecs/mc13783.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/mc13783.c b/sound/soc/codecs/mc13783.c index 2ffb9a0..3d44fc5 100644 --- a/sound/soc/codecs/mc13783.c +++ b/sound/soc/codecs/mc13783.c @@ -623,14 +623,14 @@ static int mc13783_probe(struct snd_soc_codec *codec) AUDIO_SSI_SEL, 0); else mc13xxx_reg_rmw(priv->mc13xxx, MC13783_AUDIO_CODEC, - 0, AUDIO_SSI_SEL); + AUDIO_SSI_SEL, AUDIO_SSI_SEL); if (priv->dac_ssi_port == MC13783_SSI1_PORT) mc13xxx_reg_rmw(priv->mc13xxx, MC13783_AUDIO_DAC, AUDIO_SSI_SEL, 0); else mc13xxx_reg_rmw(priv->mc13xxx, MC13783_AUDIO_DAC, - 0, AUDIO_SSI_SEL); + AUDIO_SSI_SEL, AUDIO_SSI_SEL); return 0; }