diff mbox

[2/2] sound: Close holes in struct snd_pcm_constraint_list

Message ID 1430130030-17895-2-git-send-email-lars@metafoo.de (mailing list archive)
State New, archived
Headers show

Commit Message

Lars-Peter Clausen April 27, 2015, 10:20 a.m. UTC 
On a 64-bit system there is a 32-bit hole in struct snd_pcm_constraint_list
and then 32-bit padding at the end. Reordering things slightly gets rid of
the hole and padding, reducing the size of the struct by 50% from its
original size.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 include/sound/pcm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai April 27, 2015, 10:27 a.m. UTC | #1 
At Mon, 27 Apr 2015 12:20:29 +0200,
Lars-Peter Clausen wrote:
> 
> On a 64-bit system there is a 32-bit hole in struct snd_pcm_constraint_list
> and then 32-bit padding at the end. Reordering things slightly gets rid of
> the hole and padding, reducing the size of the struct by 50% from its
> original size.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks, applied.


Takashi

> ---
>  include/sound/pcm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/sound/pcm.h b/include/sound/pcm.h
> index d632809..691e7ee 100644
> --- a/include/sound/pcm.h
> +++ b/include/sound/pcm.h
> @@ -274,8 +274,8 @@ struct snd_pcm_hw_constraint_ratdens {
>  };
>  
>  struct snd_pcm_hw_constraint_list {
> -	unsigned int count;
>  	const unsigned int *list;
> +	unsigned int count;
>  	unsigned int mask;
>  };
>  
> -- 
> 1.8.0
>
diff mbox

Patch

diff --git a/include/sound/pcm.h b/include/sound/pcm.h
index d632809..691e7ee 100644
--- a/include/sound/pcm.h
+++ b/include/sound/pcm.h
@@ -274,8 +274,8 @@  struct snd_pcm_hw_constraint_ratdens {
 };
 
 struct snd_pcm_hw_constraint_list {
-	unsigned int count;
 	const unsigned int *list;
+	unsigned int count;
 	unsigned int mask;
 };