From patchwork Tue May 12 04:23:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 6385491 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E96EABEEE1 for ; Tue, 12 May 2015 04:26:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 31588203C4 for ; Tue, 12 May 2015 04:26:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 0665620397 for ; Tue, 12 May 2015 04:26:46 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 24D9B26547F; Tue, 12 May 2015 06:26:45 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NO_DNS_FOR_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 2DDBA2654CE; Tue, 12 May 2015 06:24:59 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id ED9F12654CC; Tue, 12 May 2015 06:24:57 +0200 (CEST) Received: from mail-yk0-f172.google.com (mail-yk0-f172.google.com [209.85.160.172]) by alsa0.perex.cz (Postfix) with ESMTP id 3F1AE265368 for ; Tue, 12 May 2015 06:24:28 +0200 (CEST) Received: by ykeo186 with SMTP id o186so44242135yke.0 for ; Mon, 11 May 2015 21:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0tZ0pYe2NciyqYgN1YNhxAjsUmwCXzaPoEaPxWLcHnY=; b=KbsTwz6AQvM9YZYJhT6ECwXZ6MP8uidTxT6VLnC5Qwcc8C4BBk69CciINXfSP/qwQV Q2ay4p/6yYP6zMFbJ7Q9rH0F+wSNI0zSpLeSM4SlbD5IqRbfZBkzpZw6og89VBP8QlZE BPyyxE/4rsTq+vbYsUPnYakR89z+zxfwsU1r+vJQ8mg68fGLIy4EjjhjLMqNT32x8ABu 1MvNMs4zbzqM5rRutEUnd2l7IxKdO8hX+eaC6bao20L39azMy/1Hwe6gdUwoASwI75Ov c3kNvoJoYe0M9uj2hwZJllDMIOlbtTjMifQwpKxNpTCoRth6vOG1BcYEDYsLcTE5RWJu qnEg== X-Received: by 10.236.222.38 with SMTP id s36mr13196665yhp.170.1431404667643; Mon, 11 May 2015 21:24:27 -0700 (PDT) Received: from localhost.localdomain ([177.194.98.179]) by mx.google.com with ESMTPSA id k8sm14073447yha.18.2015.05.11.21.24.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 11 May 2015 21:24:26 -0700 (PDT) From: Fabio Estevam To: broonie@kernel.org Date: Tue, 12 May 2015 01:23:00 -0300 Message-Id: <1431404580-17991-5-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1431404580-17991-1-git-send-email-festevam@gmail.com> References: <1431404580-17991-1-git-send-email-festevam@gmail.com> Cc: Fabio Estevam , Julia.Lawall@lip6.fr, alsa-devel@alsa-project.org Subject: [alsa-devel] [PATCH 5/5] ASoC: max98095: Pass the IRQF_ONESHOT flag X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. The semantic patch that makes this change is available in scripts/coccinelle/misc/irqf_oneshot.cocci. Signed-off-by: Fabio Estevam --- sound/soc/codecs/max98095.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/max98095.c b/sound/soc/codecs/max98095.c index 66c7ca4..453a919 100644 --- a/sound/soc/codecs/max98095.c +++ b/sound/soc/codecs/max98095.c @@ -2300,8 +2300,8 @@ static int max98095_probe(struct snd_soc_codec *codec) /* register an audio interrupt */ ret = request_threaded_irq(client->irq, NULL, max98095_report_jack, - IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING, - "max98095", codec); + IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING | + IRQF_ONESHOT, "max98095", codec); if (ret) { dev_err(codec->dev, "Failed to request IRQ: %d\n", ret); goto err_access;