From patchwork Tue Jun 9 10:18:32 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inha Song X-Patchwork-Id: 6570961 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A4B77C0020 for ; Tue, 9 Jun 2015 10:19:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DFBEF20481 for ; Tue, 9 Jun 2015 10:19:16 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id A6D6E20495 for ; Tue, 9 Jun 2015 10:19:15 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 157B82651FE; Tue, 9 Jun 2015 12:19:14 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 011AE260675; Tue, 9 Jun 2015 12:19:06 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 8915D2606AD; Tue, 9 Jun 2015 12:19:04 +0200 (CEST) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by alsa0.perex.cz (Postfix) with ESMTP id 21CA226065C for ; Tue, 9 Jun 2015 12:18:57 +0200 (CEST) Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NPO00EVN9YVLG40@mailout1.samsung.com> for alsa-devel@alsa-project.org; Tue, 09 Jun 2015 19:18:31 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.116]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 65.6A.17770.E7DB6755; Tue, 9 Jun 2015 19:18:38 +0900 (KST) X-AuditID: cbfee691-f79ca6d00000456a-ac-5576bd7ec643 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 52.2F.05312.D7DB6755; Tue, 9 Jun 2015 19:18:38 +0900 (KST) Received: from songinha-Samsung-DeskTop-System.10.32.193.11 ([10.252.81.136]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NPO009869Z05Z30@mmp2.samsung.com>; Tue, 09 Jun 2015 19:18:37 +0900 (KST) From: Inha Song To: broonie@kernel.org, lee.jones@linaro.org Date: Tue, 09 Jun 2015 19:18:32 +0900 Message-id: <1433845112-371-1-git-send-email-ideal.song@samsung.com> X-Mailer: git-send-email 2.0.0.390.gcb682f8 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsWyRsSkRLdub1mowYKVvBZXLh5ispj68Amb xa6/9xkt7n89ymhxedccNovlb/+zWZzuZnVg99jwuYnNY9OqTjaPO9f2sHnMOxno8XLibzaP vi2rGD0+b5ILYI/isklJzcksSy3St0vgytjcL1pwnrNicp90A2MrRxcjJ4eEgIlE1/vXbBC2 mMSFe+uBbC4OIYGljBI/mhaxwBSdO7eAEcQWEpjOKLHzWw5E0UQmifnTbzOBJNgENCS+f97M DGKLCOhIfP54jBmkiFlgIaPE1ZlrgBwODmGBCInFvxJBalgEVCUe/uoAq+cVcJGYf2YbO8Qy bYl9DTPBrpAQaGeXeLp/IyNEg4DEt8mHWEDmSAjISmw6wAxRLylxcMUNlgmMggsYGVYxiqYW JBcUJ6UXmeoVJ+YWl+al6yXn525iBIbw6X/PJu5gvH/A+hCjAAejEg+vonJZqBBrYllxZe4h RlOgDROZpUST84GRklcSb2hsZmRhamJqbGRuaaYkzqsj/TNYSCA9sSQ1OzW1ILUovqg0J7X4 ECMTB6dUA6PSgT+dsfYz/x5RMbnHvkLwhd6dMxPELy8+kpwdnPVsX9kn8/Ryl2NPAjL6Pm27 OEfV+kWpC+8pdj/F2m0HbfpyUk27k58ENs3eeyEp7und5rxaPX5xwUtce91TV2j/uL541gnH j6LPpktrn13rZBOqFDUhwyX30gJ/YSmLqlYTznsGx0U1rZVYijMSDbWYi4oTARSpGeRcAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRmVeSWpSXmKPExsVy+t9jQd26vWWhBm2nWS2uXDzEZDH14RM2 i11/7zNa3P96lNHi8q45bBbL3/5nszjdzerA7rHhcxObx6ZVnWwed67tYfOYdzLQ4+XE32we fVtWMXp83iQXwB7VwGiTkZqYklqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk 4hOg65aZA3SPkkJZYk4pUCggsbhYSd8O04TQEDddC5jGCF3fkCC4HiMDNJCwhjFjc79owXnO isl90g2MrRxdjJwcEgImEufOLWCEsMUkLtxbzwZiCwlMZ5TY+S2ni5ELyJ7IJDF/+m0mkASb gIbE98+bmUFsEQEdic8fjzGDFDELLGSUuDpzDZDDwSEsECGx+FciSA2LgKrEw18dYPW8Ai4S 889sY4dYpi2xr2Em2wRG7gWMDKsYRVMLkguKk9JzjfSKE3OLS/PS9ZLzczcxgiPkmfQOxlUN FocYBTgYlXh4TyiUhQqxJpYVV+YeYpTgYFYS4WXpAgrxpiRWVqUW5ccXleakFh9iNAXaPpFZ SjQ5Hxi9eSXxhsYmZkaWRuaGFkbG5krivCfzfUKFBNITS1KzU1MLUotg+pg4OKUaGDV+zCqd XKUW1PJyY//Mhj+/3y458PJd4M+5zv4ceXrcCl+D6l88OytqaqvqsIjvcPynmcsijC7N4y4t zlrEOCE7qFZbWvfPjlKtWXVlM7b4Vm1PEa7VSUo/smCteFb1luzuib+anFd//vLDapdLf62H W4xavPGNQ/yGKc+SHtWqS+w50si/WomlOCPRUIu5qDgRAJnQwsOmAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, Inha Song , sameo@linux.intel.com, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH] mfd: wm8994: Fix NULL pointer exception on missing pdata X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP If we use the dev_get_platdata, pdata can be NULL in DT environments. Actually, NULL pointer exception is occurs with error messages like this: [ 1.226583] Unable to handle kernel NULL pointer dereference at virtual address 00000044 [ 1.467910] [] (wm8994_irq_init) from [] (wm8994_i2c_probe+0x684/0x858) [ 1.476241] [] (wm8994_i2c_probe) from [] (i2c_device_probe+0x11c/0x17c) In wm8994-core, we already checked wheter platform data is NULL and set the wm8994->pdata to platform data if platform data is not NULL. So, we can use wm8994->pdata instead of platform data. Signed-off-by: Inha Song Acked-by: Charles Keepax --- drivers/mfd/wm8994-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/wm8994-irq.c b/drivers/mfd/wm8994-irq.c index a14407e..ec2c891 100644 --- a/drivers/mfd/wm8994-irq.c +++ b/drivers/mfd/wm8994-irq.c @@ -193,7 +193,7 @@ int wm8994_irq_init(struct wm8994 *wm8994) { int ret; unsigned long irqflags; - struct wm8994_pdata *pdata = dev_get_platdata(wm8994->dev); + struct wm8994_pdata *pdata = &wm8994->pdata; if (!wm8994->irq) { dev_warn(wm8994->dev,