| Message ID | 1435843604.17967.1.camel@ingics.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 030e6ee241f0586308622bcdd273a317976b3169 |
| Headers | show |
On Thu, Jul 02, 2015 at 09:26:44PM +0800, Axel Lin wrote: > This reverts 58d468328646 ("ASoC: wm0010: Add missing IRQF_ONESHOT"). > > The coccinelle warnings is false positive because the original code does > set IRQF_ONESHOT by "trigger |= IRQF_ONESHOT;". > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- For the whole series: Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Thanks, Charles
On Thu, Jul 2, 2015 at 10:26 AM, Axel Lin <axel.lin@ingics.com> wrote: > This reverts 58d468328646 ("ASoC: wm0010: Add missing IRQF_ONESHOT"). > > The coccinelle warnings is false positive because the original code does > set IRQF_ONESHOT by "trigger |= IRQF_ONESHOT;". > > Signed-off-by: Axel Lin <axel.lin@ingics.com> Ops, sorry about that: Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com>
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c index 6560a66..ff924032 100644 --- a/sound/soc/codecs/wm0010.c +++ b/sound/soc/codecs/wm0010.c @@ -953,7 +953,7 @@ static int wm0010_spi_probe(struct spi_device *spi) trigger = IRQF_TRIGGER_FALLING; trigger |= IRQF_ONESHOT; - ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger | IRQF_ONESHOT, + ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger, "wm0010", wm0010); if (ret) { dev_err(wm0010->dev, "Failed to request IRQ %d: %d\n",
This reverts 58d468328646 ("ASoC: wm0010: Add missing IRQF_ONESHOT"). The coccinelle warnings is false positive because the original code does set IRQF_ONESHOT by "trigger |= IRQF_ONESHOT;". Signed-off-by: Axel Lin <axel.lin@ingics.com> --- sound/soc/codecs/wm0010.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)