From patchwork Thu Jul 2 13:26:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 6709701 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EE8ADC05AC for ; Thu, 2 Jul 2015 13:27:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 02E8A206F2 for ; Thu, 2 Jul 2015 13:27:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id BAF2D2041E for ; Thu, 2 Jul 2015 13:27:13 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 96B08265A73; Thu, 2 Jul 2015 15:27:11 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 312A72659FC; Thu, 2 Jul 2015 15:27:03 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 206CF265A12; Thu, 2 Jul 2015 15:27:01 +0200 (CEST) Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by alsa0.perex.cz (Postfix) with ESMTP id E5ABF265993 for ; Thu, 2 Jul 2015 15:26:53 +0200 (CEST) Received: by pdjd13 with SMTP id d13so45387731pdj.0 for ; Thu, 02 Jul 2015 06:26:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=/+HR+wz7dXNXf6Qwxvig5TIdPh/UJEpblW/4SLxx6DA=; b=NeeRhiVQ7Kh8QR5qkEBaSut0gsryPFQmnsIJD9ei3giVyEkaUIAiWu5PNhVFf+OtMK jCzTGIB3RTeSg6kfOAQvGJVWzGRSBVxNVF4b0YLmy5efQgNXp8JhW+2xvw5fZm2VPBN1 R6HUiv8bH3akTNCfYXhkBKFoW/hiBZCT7jp0mf4DPFue4gg/sMUmSB+/vGo1wvqRZX9s MsBs43BKLzoUdH0+aIjsxy3znsAjxPdK5WlQ6pQUmkVGnmVflLmV+0aHjW1dO3xz1rDg +uclQzzhPbOYN6o3qco/o7i18CLnEA1JhQPiVEI/IdFdI0zbxedx00+hD3yypiGYFg3y wOyw== X-Gm-Message-State: ALoCoQm5t/QDjzzi0QewyBw7brS06Fq6DCI10IKkkvKyzDlsatobCd9FPdn4mfpJIOJR3oJ0IzR9 X-Received: by 10.66.222.103 with SMTP id ql7mr65275573pac.144.1435843612068; Thu, 02 Jul 2015 06:26:52 -0700 (PDT) Received: from phoenix ([27.245.43.55]) by mx.google.com with ESMTPSA id bn5sm5734540pbc.82.2015.07.02.06.26.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jul 2015 06:26:50 -0700 (PDT) Message-ID: <1435843604.17967.1.camel@ingics.com> From: Axel Lin To: Mark Brown Date: Thu, 02 Jul 2015 21:26:44 +0800 X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Cc: Fabio Estevam , Michal Marek , alsa-devel@alsa-project.org, Lars-Peter Clausen , Liam Girdwood , Julia Lawall , Charles Keepax , Fengguang Wu Subject: [alsa-devel] [PATCH 1/3] Revert "ASoC: wm0010: Add missing IRQF_ONESHOT" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts 58d468328646 ("ASoC: wm0010: Add missing IRQF_ONESHOT"). The coccinelle warnings is false positive because the original code does set IRQF_ONESHOT by "trigger |= IRQF_ONESHOT;". Signed-off-by: Axel Lin Acked-by: Charles Keepax Reviewed-by: Fabio Estevam --- sound/soc/codecs/wm0010.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c index 6560a66..ff924032 100644 --- a/sound/soc/codecs/wm0010.c +++ b/sound/soc/codecs/wm0010.c @@ -953,7 +953,7 @@ static int wm0010_spi_probe(struct spi_device *spi) trigger = IRQF_TRIGGER_FALLING; trigger |= IRQF_ONESHOT; - ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger | IRQF_ONESHOT, + ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger, "wm0010", wm0010); if (ret) { dev_err(wm0010->dev, "Failed to request IRQ %d: %d\n",