From patchwork Thu Jul 2 13:27:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 6709711 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7DBB7C05AC for ; Thu, 2 Jul 2015 13:28:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BBE0220435 for ; Thu, 2 Jul 2015 13:28:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 8AE432041A for ; Thu, 2 Jul 2015 13:28:21 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id A3174265A17; Thu, 2 Jul 2015 15:28:20 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 473B8265A1A; Thu, 2 Jul 2015 15:28:19 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9878C265A1A; Thu, 2 Jul 2015 15:28:17 +0200 (CEST) Received: from mail-pd0-f173.google.com (mail-pd0-f173.google.com [209.85.192.173]) by alsa0.perex.cz (Postfix) with ESMTP id 967AE265ACA for ; Thu, 2 Jul 2015 15:27:56 +0200 (CEST) Received: by pdjd13 with SMTP id d13so45400485pdj.0 for ; Thu, 02 Jul 2015 06:27:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-type:mime-version:content-transfer-encoding; bh=Ivgm0zpNRm0VZMg9qjcQFFhLVl4EzZ2mtFC5JZjo4jA=; b=e+XkmsEU8R52KANvzPiCCUiGEGeMoopJdqzvxyHauFBSvtAX2RA4v+jut8/dQ6X2LQ 7zh3AoTOURi8981z16w2Qu0cnTtbg5kpXiwtFIFYLO0T7oUglVEEKiyucINqZQkXmM9x 3BH60pqYHOHvRQ0cZkm+ChEfGaiRvzEH4iQV4JsLcYOA2Dm2s7l6WJJJ0sq+l76mVLBk xLxZ3/48CGy30GJUCSb2U04/k2qyjTnlBxc3d/GWmP1ceboILtfTc0XxBXSdstCDUe/M c1qYLW0VghDL7o2Lu8geMCgP8+hs40UJhLzm3uwxZc80xWwR2+eKT/pxl1A6MBKL7eRO qMgQ== X-Gm-Message-State: ALoCoQkV6dmmSbJMKvHBLeF7p56lupirxvejk5nMH0b/vQET8QHGHRL0oEG30kG4xX+06xd3epdP X-Received: by 10.67.7.162 with SMTP id dd2mr64922114pad.151.1435843675897; Thu, 02 Jul 2015 06:27:55 -0700 (PDT) Received: from phoenix ([27.245.43.55]) by mx.google.com with ESMTPSA id fb3sm5734903pbd.91.2015.07.02.06.27.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jul 2015 06:27:55 -0700 (PDT) Message-ID: <1435843668.17967.2.camel@ingics.com> From: Axel Lin To: Mark Brown Date: Thu, 02 Jul 2015 21:27:48 +0800 In-Reply-To: <1435843604.17967.1.camel@ingics.com> References: <1435843604.17967.1.camel@ingics.com> X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Cc: Fabio Estevam , Michal Marek , alsa-devel@alsa-project.org, Lars-Peter Clausen , Liam Girdwood , Julia Lawall , Charles Keepax , Fengguang Wu Subject: [alsa-devel] [PATCH 2/3] Revert "ASoC: wm5100: Pass the IRQF_ONESHOT flag" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts 3d907cc30d07 ("ASoC: wm5100: Pass the IRQF_ONESHOT flag"). The coccinelle warnings is false positive because the original code does set IRQF_ONESHOT by "trigger |= IRQF_ONESHOT;". Signed-off-by: Axel Lin --- sound/soc/codecs/wm5100.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c index 4c10cd8..98495dd 100644 --- a/sound/soc/codecs/wm5100.c +++ b/sound/soc/codecs/wm5100.c @@ -2570,13 +2570,11 @@ static int wm5100_i2c_probe(struct i2c_client *i2c, if (irq_flags & (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING)) ret = request_threaded_irq(i2c->irq, NULL, - wm5100_edge_irq, - irq_flags | IRQF_ONESHOT, + wm5100_edge_irq, irq_flags, "wm5100", wm5100); else ret = request_threaded_irq(i2c->irq, NULL, wm5100_irq, - irq_flags | IRQF_ONESHOT, - "wm5100", + irq_flags, "wm5100", wm5100); if (ret != 0) {