From patchwork Thu Jul 2 13:29:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 6709771 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BB208C05AC for ; Thu, 2 Jul 2015 13:29:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A6EC0206EC for ; Thu, 2 Jul 2015 13:29:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 6294820435 for ; Thu, 2 Jul 2015 13:29:28 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5A40D265ADB; Thu, 2 Jul 2015 15:29:27 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 1D668265A12; Thu, 2 Jul 2015 15:29:19 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 90CC9265A23; Thu, 2 Jul 2015 15:29:17 +0200 (CEST) Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by alsa0.perex.cz (Postfix) with ESMTP id 66680265A12 for ; Thu, 2 Jul 2015 15:29:10 +0200 (CEST) Received: by pacws9 with SMTP id ws9so41426872pac.0 for ; Thu, 02 Jul 2015 06:29:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-type:mime-version:content-transfer-encoding; bh=WRhLOt1pWOfgLcrtDRrS0fdQJZYbzcC9hNRpIBWk50E=; b=JfkIex8zw4ebX/Gyd1UDYwtO02XZ5bct/ugQnwNHAH78oec0+G/eIOk7xK7nC3/2YU t2+M3K05+uvEli+Vjo5983fd1SsZHbU9fDLWB4Dur6tSPGjWnvRepm9WIsUvn2KCgRWx g+4+99YzVQx15aME4ZSjGIyHzSraAVhEkYCGStAjugsFeduAAUl0pfgXnpcqE74ziTJK jt+j6psSImuGigTOSaQmYa7Y6QBjWAAatksBD71NI2qn63/FM94qsEfwAkLh3x/RzNMA m17D46iTCrzHf4yaB7LSgTK+/WO+n1Q1Ir4ohs3vvU9UQbjENPIzNf9QXxaYStu2eNsi WAvA== X-Gm-Message-State: ALoCoQmzeAQknbirGNcAFwDE19B8v9su3GloPk+bhyPbWNcViLFlZrxDW7MHe/fjNfYZ0paZsZ4n X-Received: by 10.70.47.138 with SMTP id d10mr65136150pdn.137.1435843749397; Thu, 02 Jul 2015 06:29:09 -0700 (PDT) Received: from phoenix ([27.245.43.55]) by mx.google.com with ESMTPSA id ry2sm5739703pbb.83.2015.07.02.06.29.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jul 2015 06:29:08 -0700 (PDT) Message-ID: <1435843741.17967.3.camel@ingics.com> From: Axel Lin To: Mark Brown Date: Thu, 02 Jul 2015 21:29:01 +0800 In-Reply-To: <1435843604.17967.1.camel@ingics.com> References: <1435843604.17967.1.camel@ingics.com> X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Cc: Fabio Estevam , Michal Marek , alsa-devel@alsa-project.org, Lars-Peter Clausen , Liam Girdwood , Julia Lawall , Charles Keepax , Fengguang Wu Subject: [alsa-devel] [PATCH 3/3] Revert "ASoC: wm8996: Pass the IRQF_ONESHOT flag" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts ed043aebe6ec ("ASoC: wm8996: Pass the IRQF_ONESHOT flag"). The coccinelle warnings is false positive because the original code does set IRQF_ONESHOT by "trigger |= IRQF_ONESHOT;". Signed-off-by: Axel Lin --- sound/soc/codecs/wm8996.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm8996.c b/sound/soc/codecs/wm8996.c index 3dd063f..370459f 100644 --- a/sound/soc/codecs/wm8996.c +++ b/sound/soc/codecs/wm8996.c @@ -2647,12 +2647,10 @@ static int wm8996_probe(struct snd_soc_codec *codec) if (irq_flags & (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING)) ret = request_threaded_irq(i2c->irq, NULL, wm8996_edge_irq, - irq_flags | IRQF_ONESHOT, - "wm8996", codec); + irq_flags, "wm8996", codec); else ret = request_threaded_irq(i2c->irq, NULL, wm8996_irq, - irq_flags | IRQF_ONESHOT, - "wm8996", codec); + irq_flags, "wm8996", codec); if (ret == 0) { /* Unmask the interrupt */