From patchwork Wed Jul 22 03:27:45 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 6839251 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 25368C05AC for ; Wed, 22 Jul 2015 03:28:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 626DC203A9 for ; Wed, 22 Jul 2015 03:28:11 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 3783B20251 for ; Wed, 22 Jul 2015 03:28:10 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id A6960260676; Wed, 22 Jul 2015 05:28:08 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, RCVD_IN_DNSWL_NONE,UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 4049B26062A; Wed, 22 Jul 2015 05:28:00 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7D37826065E; Wed, 22 Jul 2015 05:27:59 +0200 (CEST) Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by alsa0.perex.cz (Postfix) with ESMTP id 3ED4E2605FF for ; Wed, 22 Jul 2015 05:27:52 +0200 (CEST) Received: by pdbbh15 with SMTP id bh15so85384727pdb.1 for ; Tue, 21 Jul 2015 20:27:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=S6CY4cQwqQSZz4gQN34nG8Nw3hrxZQ/RDQYZ6/O7R+E=; b=VLwGEiTwaf5hYIq4khfE0Ty/bkVEnWW2UOEefhzrQGvWDq1QckmGDOgHa1/+pmqbxR GsXihGXWAdl2VFT1DEzCxs2D+NzHJbTRyIG5XES1LGTAg+KONXPLGMyrNFzZW+R72aQd DNQjWg7Mwcs3KY9anRelG/fU67jDdVVbJeNAmymWBw4hGhzaC1m1D4y99n5yVOMvHhVb NH1+5l5aT7kj0cDYk3B5247zfginBBSP0+hMQf/8512DJLzxmgy01wX+P0QddNDPItT/ r3RNoyrIz4asTVYd0I9NIbvoktlA7P8nNMGuzL00lp8HY39YSdF/cg2qZ0bmB0N/077C rmaw== X-Gm-Message-State: ALoCoQl/FlfvT4+ldyqujH92beFePpJksswtkLur1CmsV2PzJaDy5cQLaQvoWHgxHeMKFN18kEVi X-Received: by 10.66.142.199 with SMTP id ry7mr910531pab.14.1437535670667; Tue, 21 Jul 2015 20:27:50 -0700 (PDT) Received: from phoenix (1-169-147-33.dynamic.hinet.net. [1.169.147.33]) by smtp.gmail.com with ESMTPSA id a4sm121645pdm.85.2015.07.21.20.27.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Jul 2015 20:27:49 -0700 (PDT) Message-ID: <1437535665.17780.1.camel@ingics.com> From: Axel Lin To: Mark Brown Date: Wed, 22 Jul 2015 11:27:45 +0800 X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Cc: Fabio Estevam , alsa-devel@alsa-project.org, Zeng Zhaoming , Liam Girdwood , Filip Brozovic , Alexander Stein Subject: [alsa-devel] [PATCH RFT] ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, below code actually does not update any bit because SGTL5000_SMALL_POP is 0. snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1); The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it. Signed-off-by: Axel Lin Acked-By: Alexander Stein Reviewed-by: Fabio Estevam --- Hi, I don't have h/w and datasheet, but the code looks obvious does not make sense. Can someone help to confirm and test if this patch? Thanks, Axel sound/soc/codecs/sgtl5000.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h index bd7a344..1c317de 100644 --- a/sound/soc/codecs/sgtl5000.h +++ b/sound/soc/codecs/sgtl5000.h @@ -275,7 +275,7 @@ #define SGTL5000_BIAS_CTRL_MASK 0x000e #define SGTL5000_BIAS_CTRL_SHIFT 1 #define SGTL5000_BIAS_CTRL_WIDTH 3 -#define SGTL5000_SMALL_POP 0 +#define SGTL5000_SMALL_POP 1 /* * SGTL5000_CHIP_MIC_CTRL