| Message ID | 1437987388-9706-5-git-send-email-lars@metafoo.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b917abb4064b38b0613e953b09213e788ad94ad0 |
| Headers | show |
Hi On 07/27/2015 10:56 AM, Lars-Peter Clausen wrote: > base referes to a iomem region, so it should have the __iomem annotation. > Fixes the following warnings from sparse: > > sound/soc/sti/sti_uniperif.c:169:19: warning: incorrect type in > assignment (different address spaces) > sound/soc/sti/sti_uniperif.c:169:19: expected void *base > sound/soc/sti/sti_uniperif.c:169:19: got void [noderef] <asn:2>* > sound/soc/sti/uniperif_player.c:104:18: warning: incorrect type in > argument 1 (different address spaces) > sound/soc/sti/uniperif_player.c:104:18: expected void const volatile > [noderef] <asn:2>*addr > sound/soc/sti/uniperif_player.c:104:18: got void * > [...] > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > --- > sound/soc/sti/uniperif.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h > index ee462f7..f0fd5a9 100644 > --- a/sound/soc/sti/uniperif.h > +++ b/sound/soc/sti/uniperif.h > @@ -1168,7 +1168,7 @@ struct uniperif { > > /* Resources */ > struct resource *mem_region; > - void *base; > + void __iomem *base; > unsigned long fifo_phys_address; > int irq; > > Thanks for the patch, acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> Br, Arnaud
diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h index ee462f7..f0fd5a9 100644 --- a/sound/soc/sti/uniperif.h +++ b/sound/soc/sti/uniperif.h @@ -1168,7 +1168,7 @@ struct uniperif { /* Resources */ struct resource *mem_region; - void *base; + void __iomem *base; unsigned long fifo_phys_address; int irq;
base referes to a iomem region, so it should have the __iomem annotation. Fixes the following warnings from sparse: sound/soc/sti/sti_uniperif.c:169:19: warning: incorrect type in assignment (different address spaces) sound/soc/sti/sti_uniperif.c:169:19: expected void *base sound/soc/sti/sti_uniperif.c:169:19: got void [noderef] <asn:2>* sound/soc/sti/uniperif_player.c:104:18: warning: incorrect type in argument 1 (different address spaces) sound/soc/sti/uniperif_player.c:104:18: expected void const volatile [noderef] <asn:2>*addr sound/soc/sti/uniperif_player.c:104:18: got void * [...] Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- sound/soc/sti/uniperif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)