| Message ID | 1437987388-9706-7-git-send-email-lars@metafoo.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d32e03f0b6f9b4ad260feca1c5c938a882066de9 |
| Headers | show |
On Mon, Jul 27, 2015 at 11:56 AM, Lars-Peter Clausen <lars@metafoo.de> wrote: > tx_substeam is accessed using the RCU API and hence should have the __rcu > annotation. Fixes the following sparse warnings: > > sound/soc/xtensa/xtfpga-i2s.c:165:24: error: incompatible types in > comparison expression (different address spaces) > sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream > [noderef] <asn:4>*' versus > sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream *' > sound/soc/xtensa/xtfpga-i2s.c:255:24: error: incompatible types in > comparison expression (different address spaces) > sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream > [noderef] <asn:4>*' versus > sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream *' > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > --- > sound/soc/xtensa/xtfpga-i2s.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thank you for the fix, Lars-Peter. Acked-by: Max Filippov <jcmvbkbc@gmail.com>
diff --git a/sound/soc/xtensa/xtfpga-i2s.c b/sound/soc/xtensa/xtfpga-i2s.c index 039f65e..8382ffa 100644 --- a/sound/soc/xtensa/xtfpga-i2s.c +++ b/sound/soc/xtensa/xtfpga-i2s.c @@ -75,7 +75,7 @@ struct xtfpga_i2s { * stream in the pcm_close callback it synchronizes with the interrupt * handler by means of synchronize_rcu call. */ - struct snd_pcm_substream *tx_substream; + struct snd_pcm_substream __rcu *tx_substream; unsigned (*tx_fn)(struct xtfpga_i2s *i2s, struct snd_pcm_runtime *runtime, unsigned tx_ptr);
tx_substeam is accessed using the RCU API and hence should have the __rcu annotation. Fixes the following sparse warnings: sound/soc/xtensa/xtfpga-i2s.c:165:24: error: incompatible types in comparison expression (different address spaces) sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream [noderef] <asn:4>*' versus sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream *' sound/soc/xtensa/xtfpga-i2s.c:255:24: error: incompatible types in comparison expression (different address spaces) sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream [noderef] <asn:4>*' versus sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream *' Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- sound/soc/xtensa/xtfpga-i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)