From patchwork Mon Jul 27 08:56:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lars-Peter Clausen X-Patchwork-Id: 6869821 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 75D8FC05AC for ; Mon, 27 Jul 2015 08:58:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 98D3420658 for ; Mon, 27 Jul 2015 08:58:26 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 65A532062A for ; Mon, 27 Jul 2015 08:58:25 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9630D265090; Mon, 27 Jul 2015 10:58:24 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 6C692261AED; Mon, 27 Jul 2015 10:56:50 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B2051261A96; Mon, 27 Jul 2015 10:56:45 +0200 (CEST) Received: from smtp-out-193.synserver.de (smtp-out-193.synserver.de [212.40.185.193]) by alsa0.perex.cz (Postfix) with ESMTP id E1DB22619E7 for ; Mon, 27 Jul 2015 10:56:39 +0200 (CEST) Received: (qmail 17449 invoked by uid 0); 27 Jul 2015 08:56:39 -0000 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 16958 Received: from p4fde72e8.dip0.t-ipconnect.de (HELO lars-laptop.ad.analog.com) [79.222.114.232] by 217.119.54.87 with SMTP; 27 Jul 2015 08:56:39 -0000 From: Lars-Peter Clausen To: Mark Brown , Liam Girdwood Date: Mon, 27 Jul 2015 10:56:28 +0200 Message-Id: <1437987388-9706-7-git-send-email-lars@metafoo.de> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1437987388-9706-1-git-send-email-lars@metafoo.de> References: <1437987388-9706-1-git-send-email-lars@metafoo.de> Cc: alsa-devel@alsa-project.org, Banajit Goswami , Kuninori Morimoto , Patrick Lai , patches@opensource.wolfsonmicro.com, Arnaud Pouliquen , Max Filippov , Lars-Peter Clausen , Charles Keepax Subject: [alsa-devel] [PATCH 6/6] ASoC: xtfpga-i2s: Add missing __rcu annotation X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP tx_substeam is accessed using the RCU API and hence should have the __rcu annotation. Fixes the following sparse warnings: sound/soc/xtensa/xtfpga-i2s.c:165:24: error: incompatible types in comparison expression (different address spaces) sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream [noderef] *' versus sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream *' sound/soc/xtensa/xtfpga-i2s.c:255:24: error: incompatible types in comparison expression (different address spaces) sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream [noderef] *' versus sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream *' Signed-off-by: Lars-Peter Clausen Acked-by: Max Filippov --- sound/soc/xtensa/xtfpga-i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/xtensa/xtfpga-i2s.c b/sound/soc/xtensa/xtfpga-i2s.c index 039f65e..8382ffa 100644 --- a/sound/soc/xtensa/xtfpga-i2s.c +++ b/sound/soc/xtensa/xtfpga-i2s.c @@ -75,7 +75,7 @@ struct xtfpga_i2s { * stream in the pcm_close callback it synchronizes with the interrupt * handler by means of synchronize_rcu call. */ - struct snd_pcm_substream *tx_substream; + struct snd_pcm_substream __rcu *tx_substream; unsigned (*tx_fn)(struct xtfpga_i2s *i2s, struct snd_pcm_runtime *runtime, unsigned tx_ptr);