diff mbox

[1/2] ASoC: wm8731: Drop wm8731_writeable function

Message ID 1438394622.6442.1.camel@ingics.com (mailing list archive)
State Accepted
Commit f611cdd8eb33ac6ca1196319b27b7f7f24ef98a9
Headers show

Commit Message

Axel Lin Aug. 1, 2015, 2:03 a.m. UTC
When .max_register is set and .writeable_reg is not implement, registers
between 0 and .max_register are writeable. This is the same as current
implementation of wm8731_writeable(), so just drop implementation for
.writeable_reg callback.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 sound/soc/codecs/wm8731.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Charles Keepax Aug. 6, 2015, 4:24 p.m. UTC | #1
On Sat, Aug 01, 2015 at 10:03:42AM +0800, Axel Lin wrote:
> When .max_register is set and .writeable_reg is not implement, registers
> between 0 and .max_register are writeable. This is the same as current
> implementation of wm8731_writeable(), so just drop implementation for
> .writeable_reg callback.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles
diff mbox

Patch

diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c
index c862232..ace8645 100644
--- a/sound/soc/codecs/wm8731.c
+++ b/sound/soc/codecs/wm8731.c
@@ -79,11 +79,6 @@  static bool wm8731_volatile(struct device *dev, unsigned int reg)
 	return reg == WM8731_RESET;
 }
 
-static bool wm8731_writeable(struct device *dev, unsigned int reg)
-{
-	return reg <= WM8731_RESET;
-}
-
 #define wm8731_reset(m)	regmap_write(m, WM8731_RESET, 0)
 
 static const char *wm8731_input_select[] = {"Line In", "Mic"};
@@ -655,7 +650,6 @@  static const struct regmap_config wm8731_regmap = {
 
 	.max_register = WM8731_RESET,
 	.volatile_reg = wm8731_volatile,
-	.writeable_reg = wm8731_writeable,
 
 	.cache_type = REGCACHE_RBTREE,
 	.reg_defaults = wm8731_reg_defaults,