From patchwork Fri Aug 7 01:35:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inha Song X-Patchwork-Id: 6963871 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BAA429F38B for ; Fri, 7 Aug 2015 01:36:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DE5422076F for ; Fri, 7 Aug 2015 01:36:30 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id AB7D920690 for ; Fri, 7 Aug 2015 01:36:29 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 87FD62606C9; Fri, 7 Aug 2015 03:36:23 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id ECBA026065A; Fri, 7 Aug 2015 03:36:15 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 3190526065C; Fri, 7 Aug 2015 03:36:14 +0200 (CEST) Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by alsa0.perex.cz (Postfix) with ESMTP id A5B80260647 for ; Fri, 7 Aug 2015 03:36:06 +0200 (CEST) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NSO00NAZV44ZH50@mailout3.samsung.com> for alsa-devel@alsa-project.org; Fri, 07 Aug 2015 10:36:04 +0900 (KST) Received: from epcpsbgm2new.samsung.com ( [172.20.52.115]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 2A.C6.28411.38B04C55; Fri, 7 Aug 2015 10:36:04 +0900 (KST) X-AuditID: cbfee68e-f79c56d000006efb-1f-55c40b830245 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id AC.01.07062.38B04C55; Fri, 7 Aug 2015 10:36:03 +0900 (KST) Received: from songinha-Samsung-DeskTop-System.10.32.193.11 ([10.252.81.136]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NSO00KE4V41S760@mmp1.samsung.com>; Fri, 07 Aug 2015 10:36:03 +0900 (KST) From: Inha Song To: broonie@kernel.org, lee.jones@linaro.org Date: Fri, 07 Aug 2015 10:35:59 +0900 Message-id: <1438911359-26949-1-git-send-email-ideal.song@samsung.com> X-Mailer: git-send-email 2.0.0.390.gcb682f8 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsWyRsSkWLeF+0ioweuHTBZXLh5ispj68Amb xb8pN9gtdv29z2hx/+tRRovLu+awWSx/+5/N4nQ3qwOHx4bPTWwem1Z1snncubaHzWPeyUCP lxN/s3n0bVnF6PF5k1wAexSXTUpqTmZZapG+XQJXxvT9h5kKJnBVbH4zg62B8SBHFyMnh4SA icTdH90sELaYxIV769m6GLk4hARWMEpsOzSJGabozMGnzBCJpYwSzXPeMoEkhAQmMklM2sgO YrMJaEh8/7wZrEFEQEfi88djYDazwDFGiY3fxUBsYYE4id3nTrCC2CwCqhI/ztwG28wr4CYx 9fB3Rohl2hL7GmaCXSEhMJ1dov37YRaIBgGJb5MPAdkcQAlZiU0HoI6TlDi44gbLBEbBBYwM qxhFUwuSC4qT0ouM9IoTc4tL89L1kvNzNzECA/r0v2d9OxhvHrA+xCjAwajEw5v473CoEGti WXFl7iFGU6ANE5mlRJPzgXGTVxJvaGxmZGFqYmpsZG5ppiTOmyD1M1hIID2xJDU7NbUgtSi+ qDQntfgQIxMHp1QDo16MIHd++P26jD9R5b+emL7abO5VeeHm3JV8Tvp3QnTk4hZYd7x0OJjI PVm4z1R6Ej9v2KSotdpH7IX8TA5uOKgfmtecctjhvf8qx+gI5ofsHkE966eH18nXTrls3qcs lxex+endqCbPn9PDkyc1R5t/4Tt5fGPfRnEHZu53qxbMn3vJjrlRiaU4I9FQi7moOBEArwi7 y2MCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsVy+t9jAd1m7iOhBq17rCyuXDzEZDH14RM2 i39TbrBb7Pp7n9Hi/tejjBaXd81hs1j+9j+bxeluVgcOjw2fm9g8Nq3qZPO4c20Pm8e8k4Ee Lyf+ZvPo27KK0ePzJrkA9qgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8 xNxUWyUXnwBdt8wcoKOUFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqGBMH1GBmggYQ1jBnT 9x9mKpjAVbH5zQy2BsaDHF2MnBwSAiYSZw4+ZYawxSQu3FvP1sXIxSEksJRRonnOWyaQhJDA RCaJSRvZQWw2AQ2J7583gzWICOhIfP54DMxmFjjGKLHxuxiILSwQJ7H73AlWEJtFQFXix5nb LCA2r4CbxNTD3xkhlmlL7GuYyTaBkXsBI8MqRonUguSC4qT0XKO81HK94sTc4tK8dL3k/NxN jOCoeSa9g/HwLvdDjAIcjEo8vAn/DocKsSaWFVfmHmKU4GBWEuF9qA8U4k1JrKxKLcqPLyrN SS0+xGgKdMBEZinR5HxgROeVxBsam5gZWRqZG1oYGZsrifPqm2wKFRJITyxJzU5NLUgtgulj 4uCUamBcKf17jvv6iPkt6pbMk47Pf3uyIUBa7cOq3xYV8b+9uLxCnh+x2fmzcfNV+w3z1mgd 8U/dVyF5/7Xn/ITQGxbHn2//+mPG9lrtMy8ffHno9NlsUeWyb39aptTqx2de+KEXsvztQadL 0xa6d3/csXb2Dy8uk4yT/i7bT51TtTd4M63z8J+M7JP3BJVYijMSDbWYi4oTAYQFJwSwAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: alsa-devel@alsa-project.org, sameo@linux.intel.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, ckeepax@opensource.wolfsonmicro.com, Inha Song Subject: [alsa-devel] [RESEND PATCH] mfd: wm8994: Fix NULL pointer exception on missing pdata X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP If we use the dev_get_platdata, pdata can be NULL in DT environments. Actually, NULL pointer exception is occurs with error messages like this: [ 1.226583] Unable to handle kernel NULL pointer dereference at virtual address 00000044 [ 1.467910] [] (wm8994_irq_init) from [] (wm8994_i2c_probe+0x684/0x858) [ 1.476241] [] (wm8994_i2c_probe) from [] (i2c_device_probe+0x11c/0x17c) In wm8994-core, we already checked whether platform data is NULL and set the wm8994->pdata to platform data if platform data is not NULL. So, we can use wm8994->pdata instead of platform data. Signed-off-by: Inha Song Acked-by: Charles Keepax --- drivers/mfd/wm8994-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/wm8994-irq.c b/drivers/mfd/wm8994-irq.c index 55c380a..55c59d9 100644 --- a/drivers/mfd/wm8994-irq.c +++ b/drivers/mfd/wm8994-irq.c @@ -193,7 +193,7 @@ int wm8994_irq_init(struct wm8994 *wm8994) { int ret; unsigned long irqflags; - struct wm8994_pdata *pdata = dev_get_platdata(wm8994->dev); + struct wm8994_pdata *pdata = &wm8994->pdata; if (!wm8994->irq) { dev_warn(wm8994->dev,