From patchwork Fri Aug 14 09:58:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 7013581 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F3AEEC05AC for ; Fri, 14 Aug 2015 09:59:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 20A9B207BF for ; Fri, 14 Aug 2015 09:59:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id CE1E62041F for ; Fri, 14 Aug 2015 09:59:18 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id ED4C6265152; Fri, 14 Aug 2015 11:59:17 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 7FBF22651FE; Fri, 14 Aug 2015 11:58:46 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id BBCEF26533D; Fri, 14 Aug 2015 11:58:44 +0200 (CEST) Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com [209.85.192.174]) by alsa0.perex.cz (Postfix) with ESMTP id BB90D265152 for ; Fri, 14 Aug 2015 11:58:06 +0200 (CEST) Received: by pdbfa8 with SMTP id fa8so29668719pdb.1 for ; Fri, 14 Aug 2015 02:58:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=4IzuMza1lkA40g8KqwAWV2Q7rO7Hb2FS+QU0URD/G8A=; b=LwapzAQyQO4AlsdQddUpiAQboycHgu5J4B/4iC8VcBsyUXTVAB0UVrONx4ZArdLrUs naIJ6idQc/V3X9/VZdqgEIHRyDRh6MHwc7nkRODAscSXvFhbowrFAA5sepUR0VrH7IaT FmUSAzVAGHet5dLM8eAh1EmjdKRvecGVreomo0UKtiBhiDBB3zRqx9XqaH3dHjhlDlTR d358QsJwFfvL4ciPhAmP/o6wmCgcGoHE/BYb3V24ocp65CtJ2EGI4EWmq3iNEDZYrIzC S0KVk/2V/b29rY6EoTXTQDLEjM8YovEuoKbDJ76xkrBggH3iSgQdjamY/q/oogQLqMkq Xteg== X-Gm-Message-State: ALoCoQmFIM2CupLJFY0QVE8Wb3ZsjIMDupn4ZCb8qSJ8glEI3YlG/hQi/mS5NY4A1uBaCNiKoZHJ X-Received: by 10.70.48.72 with SMTP id j8mr14566619pdn.99.1439546284792; Fri, 14 Aug 2015 02:58:04 -0700 (PDT) Received: from phoenix (1-161-125-140.dynamic.hinet.net. [1.161.125.140]) by smtp.gmail.com with ESMTPSA id q5sm1242754pdc.65.2015.08.14.02.58.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Aug 2015 02:58:04 -0700 (PDT) Message-ID: <1439546281.5150.2.camel@ingics.com> From: Axel Lin To: Mark Brown Date: Fri, 14 Aug 2015 17:58:01 +0800 X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Cc: Charles Keepax , patches@opensource.wolfsonmicro.com, Liam Girdwood , alsa-devel@alsa-project.org Subject: [alsa-devel] [PATCH] ASoC: wm8741: Drop misleading readable_reg callback implementation X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP regmap_readable() returns false if map->format.format_write is set. For .reg_bits = 7, .val_bits = 9, setting, map->format.format_write = regmap_format_7_9_write; Even current code has implemented map->readable_reg, regmap_readable() still returns false anyway. Thus drop the misleading readable_reg callback implementation. Signed-off-by: Axel Lin Acked-by: Charles Keepax --- sound/soc/codecs/wm8741.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/sound/soc/codecs/wm8741.c b/sound/soc/codecs/wm8741.c index 9723e44..de42c03 100644 --- a/sound/soc/codecs/wm8741.c +++ b/sound/soc/codecs/wm8741.c @@ -61,25 +61,6 @@ static const struct reg_default wm8741_reg_defaults[] = { { 32, 0x0002 }, /* R32 - ADDITONAL_CONTROL_1 */ }; -static bool wm8741_readable(struct device *dev, unsigned int reg) -{ - switch (reg) { - case WM8741_DACLLSB_ATTENUATION: - case WM8741_DACLMSB_ATTENUATION: - case WM8741_DACRLSB_ATTENUATION: - case WM8741_DACRMSB_ATTENUATION: - case WM8741_VOLUME_CONTROL: - case WM8741_FORMAT_CONTROL: - case WM8741_FILTER_CONTROL: - case WM8741_MODE_CONTROL_1: - case WM8741_MODE_CONTROL_2: - case WM8741_ADDITIONAL_CONTROL_1: - return true; - default: - return false; - } -} - static int wm8741_reset(struct snd_soc_codec *codec) { return snd_soc_write(codec, WM8741_RESET, 0); @@ -541,8 +522,6 @@ static const struct regmap_config wm8741_regmap = { .reg_defaults = wm8741_reg_defaults, .num_reg_defaults = ARRAY_SIZE(wm8741_reg_defaults), .cache_type = REGCACHE_RBTREE, - - .readable_reg = wm8741_readable, }; static int wm8741_set_pdata(struct device *dev, struct wm8741_priv *wm8741)