From patchwork Fri Sep 18 10:32:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 7214891 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D3D2FBEEC1 for ; Fri, 18 Sep 2015 10:32:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1FE082094B for ; Fri, 18 Sep 2015 10:32:55 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id DBE0A20948 for ; Fri, 18 Sep 2015 10:32:53 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id E771D265B55; Fri, 18 Sep 2015 12:32:51 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NO_DNS_FOR_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 2DAA1260423; Fri, 18 Sep 2015 12:32:41 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 18B3F26042B; Fri, 18 Sep 2015 12:32:40 +0200 (CEST) Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by alsa0.perex.cz (Postfix) with ESMTP id DFBEB260412 for ; Fri, 18 Sep 2015 12:32:32 +0200 (CEST) Received: by pacfv12 with SMTP id fv12so48810373pac.2 for ; Fri, 18 Sep 2015 03:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=MCpkyo/gKI6lYxK/zfHCMj/AJNqm9S6DF73ODxtJoJQ=; b=Y98TZuFum4uKMCEM9IpG5EXrVI835A+sE94U2Pjw3fYsv5p+whiARR3oREC5kp/8lO 8RjBzfal4GbeGgjMRrIX7+8MBcxMjncxUCNQtn0l7sqEeMTO//OrSOxOqDDwgDiyonA7 6AThVebsz7q7GTaXg+8AC8kRHQto00ZSH+n8v4fXCtFocfOaxBzSlVPwB+RARSmezkX/ xi00mVUrCZoGoGRridAk8aa+CNmCNsoBPcChcbujsf9u82S5TzvJOEz7xaCFCqc0u+qj cidmEVbhTCpJ1OGnMzue7tS5UwXbQq45lxpiUFimrfpgix7H2zK296Xq3kLzVxowtpJN bo8A== X-Received: by 10.66.163.136 with SMTP id yi8mr6536550pab.124.1442572351465; Fri, 18 Sep 2015 03:32:31 -0700 (PDT) Received: from localhost.localdomain ([49.206.249.64]) by smtp.gmail.com with ESMTPSA id cn4sm8224775pbc.94.2015.09.18.03.32.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 18 Sep 2015 03:32:30 -0700 (PDT) From: Sudip Mukherjee To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Date: Fri, 18 Sep 2015 16:02:19 +0530 Message-Id: <1442572341-28201-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [alsa-devel] [PATCH 1/3] ASoC: wm0010: disable regulator on error X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP We have done regulator_bulk_enable() while booting the DSP but on the error exit path we have not disbled it. Signed-off-by: Sudip Mukherjee --- sound/soc/codecs/wm0010.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c index 8434d45..79a7cd3 100644 --- a/sound/soc/codecs/wm0010.c +++ b/sound/soc/codecs/wm0010.c @@ -739,8 +739,6 @@ static int wm0010_boot(struct snd_soc_codec *codec) abort: /* Put the chip back into reset */ wm0010_halt(codec); - mutex_unlock(&wm0010->lock); - return ret; err_core: mutex_unlock(&wm0010->lock);