From patchwork Mon Nov 23 11:08:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 7679691 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6561C9F1D3 for ; Mon, 23 Nov 2015 11:09:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 90D55206D8 for ; Mon, 23 Nov 2015 11:09:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 534DF206D6 for ; Mon, 23 Nov 2015 11:09:21 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id E8C38265368; Mon, 23 Nov 2015 12:09:19 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NO_DNS_FOR_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 133E026524F; Mon, 23 Nov 2015 12:09:10 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 230A12652D7; Mon, 23 Nov 2015 12:09:09 +0100 (CET) Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by alsa0.perex.cz (Postfix) with ESMTP id 021AB265238 for ; Mon, 23 Nov 2015 12:09:02 +0100 (CET) Received: by pacdm15 with SMTP id dm15so188265725pac.3 for ; Mon, 23 Nov 2015 03:08:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=CPXikfsak55oyihYVYy8A5i8uxR7YMtNJveJoZNUk2M=; b=P9HhH+BqCYoo/UtzFuJN3mdWoJl+lDIc8Mlh3cLrwVv6nqiErNy/paGD/ZraPZcGA2 S4g08GFIUXUpXCnFdyiiIWjP8XpgtgRUg8Z36TSS1nDFuanqg7lMkbc4vIKPPWZfWHPe U7+rBWei1aPyeDBVdQH8q6XUj4q3rrViF6ojPrFKdMkBdQDBzSm9MFF+sdcBKwGOl8BE fa4iBmYU2JFdfOJE7QboClbBtorzam2ARQTYDRVaTRBKjhXVmEyYj/drwV8W/YUKLhrp w4mkQWulIAlwTvowUF6UNNhxyqi3Kown8BdY/V3dgTS4NWXoKJYk3k1ahdJ0rvmu1Wtn XYiQ== X-Received: by 10.66.100.199 with SMTP id fa7mr35053175pab.149.1448276937429; Mon, 23 Nov 2015 03:08:57 -0800 (PST) Received: from sudip-pc.vectortproxy.org ([122.169.181.80]) by smtp.gmail.com with ESMTPSA id pb9sm10056522pac.38.2015.11.23.03.08.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 23 Nov 2015 03:08:56 -0800 (PST) From: Sudip Mukherjee To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Date: Mon, 23 Nov 2015 16:38:48 +0530 Message-Id: <1448276928-9081-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [alsa-devel] [PATCH] ASoC: Intel: Skylake: fix memory leak X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP We have requested the firmware but missed releasing it. Signed-off-by: Sudip Mukherjee --- sound/soc/intel/skylake/skl-topology.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 0937ea2..87b9c3e 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -1251,6 +1251,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus) */ ret = snd_soc_tplg_component_load(&platform->component, &skl_tplg_ops, fw, 0); + release_firmware(fw); if (ret < 0) { dev_err(bus->dev, "tplg component load failed%d\n", ret); return -EINVAL;