| Message ID | 1456209914-13375-1-git-send-email-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 127a9cbb5860a7cf15f4d4703ab0454e4603e8ac |
| Headers | show |
2016-02-23 14:45 GMT+08:00 Andrzej Hajda <a.hajda@samsung.com>: > value variable can contain error values and is compared with zero. > Its type must be signed. Reviewed-by: Axel Lin <axel.lin@ingics.com>
diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c index ab7a94d..4fb6fc7 100755 --- a/sound/soc/codecs/max9867.c +++ b/sound/soc/codecs/max9867.c @@ -180,7 +180,8 @@ static int max9867_dai_hw_params(struct snd_pcm_substream *substream, { struct snd_soc_codec *codec = dai->codec; struct max9867_priv *max9867 = snd_soc_codec_get_drvdata(codec); - unsigned int ni_h, ni_l, value; + unsigned int ni_h, ni_l; + int value; value = get_ni_value(max9867->sysclk, params_rate(params)); if (value < 0)
value variable can contain error values and is compared with zero. Its type must be signed. The problem has been detected using coccinelle script scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- sound/soc/codecs/max9867.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)