diff mbox

ASoC: Intel: Skylake: Fix kbuild dependency

Message ID 1458312023-20167-1-git-send-email-vinod.koul@intel.com (mailing list archive)
State Accepted
Commit c3efb42b207e22991dee86ca15861ede11a419fc
Headers show

Commit Message

Vinod Koul March 18, 2016, 2:40 p.m. UTC 
The Skylake driver selects SND_HDA_I915 which causes kbuild to spew warning:

  warning: (SND_SOC_INTEL_SKYLAKE) selects SND_HDA_I915 which has unmet direct dependencies
  (SOUND && !M68K && !UML && SND && DRM_I915 && SND_HDA_CORE)

The SND_HDA_I915 should not be selected so drop that.

Reported-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Takashi Iwai March 18, 2016, 5:34 p.m. UTC | #1 
On Fri, 18 Mar 2016 15:40:23 +0100,
Vinod Koul wrote:
> 
> The Skylake driver selects SND_HDA_I915 which causes kbuild to spew warning:
> 
>   warning: (SND_SOC_INTEL_SKYLAKE) selects SND_HDA_I915 which has unmet direct dependencies
>   (SOUND && !M68K && !UML && SND && DRM_I915 && SND_HDA_CORE)
> 
> The SND_HDA_I915 should not be selected so drop that.
> 
> Reported-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>

Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi


> ---
>  sound/soc/intel/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index b3e6c2300457..1120f4f4d011 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -163,7 +163,6 @@ config SND_SOC_INTEL_SKYLAKE
>  	tristate
>  	select SND_HDA_EXT_CORE
>  	select SND_SOC_TOPOLOGY
> -	select SND_HDA_I915
>  	select SND_SOC_INTEL_SST
>  
>  config SND_SOC_INTEL_SKL_RT286_MACH
> -- 
> 1.9.1
>
diff mbox

Patch

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index b3e6c2300457..1120f4f4d011 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -163,7 +163,6 @@  config SND_SOC_INTEL_SKYLAKE
 	tristate
 	select SND_HDA_EXT_CORE
 	select SND_SOC_TOPOLOGY
-	select SND_HDA_I915
 	select SND_SOC_INTEL_SST
 
 config SND_SOC_INTEL_SKL_RT286_MACH