diff mbox

[v4,1/4] dt-bindings: sound: add bindings for the max9860 codec

Message ID 1463260181-21344-2-git-send-email-peda@axentia.se (mailing list archive)
State Accepted
Commit e1f90fc2d2767145c64fad838e29d1a43abb4792
Headers show

Commit Message

Peter Rosin May 14, 2016, 9:09 p.m. UTC 
This adds the device tree binding documentation for the Maxim Integrated
MAX9860 mono audio voice codec.

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Peter Rosin <peda@axentia.se>
---
 .../devicetree/bindings/sound/max9860.txt          | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/max9860.txt

Comments

Mark Brown May 27, 2016, 8:24 p.m. UTC | #1 
On Sat, May 14, 2016 at 11:09:38PM +0200, Peter Rosin wrote:
> This adds the device tree binding documentation for the Maxim Integrated
> MAX9860 mono audio voice codec.

Please submit patches using subject lines reflecting the style for the
subsystem.  This makes it easier for people to identify relevant
patches.
Peter Rosin May 27, 2016, 8:40 p.m. UTC | #2 
On 2016-05-27 22:24, Mark Brown wrote:
> On Sat, May 14, 2016 at 11:09:38PM +0200, Peter Rosin wrote:
>> This adds the device tree binding documentation for the Maxim Integrated
>> MAX9860 mono audio voice codec.
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem.  This makes it easier for people to identify relevant
> patches.

Ok, but to me it was obviously not obvious if I submitted this patch to
ASoC or if I submitted it to devicetree.

Should I resend over this detail or will you fix it up?

Cheers,
Peter
Mark Brown May 27, 2016, 8:45 p.m. UTC | #3 
On Fri, May 27, 2016 at 10:40:07PM +0200, Peter Rosin wrote:

> Ok, but to me it was obviously not obvious if I submitted this patch to
> ASoC or if I submitted it to devicetree.

> Should I resend over this detail or will you fix it up?

It's OK, I've applied it already.
Peter Rosin May 27, 2016, 9:07 p.m. UTC | #4 
On 2016-05-27 22:45, Mark Brown wrote:
> On Fri, May 27, 2016 at 10:40:07PM +0200, Peter Rosin wrote:
> 
>> Ok, but to me it was obviously not obvious if I submitted this patch to
>> ASoC or if I submitted it to devicetree.
> 
>> Should I resend over this detail or will you fix it up?
> 
> It's OK, I've applied it already.

Great, thanks!

*me peeks at the .../sound.git repo*

You have named the topic branch topic/max8960, which should be
topic/max9860. I guess wm89.. is hard-wired into your fingers :-)

(In case it matters)

Cheers,
Peter
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/sound/max9860.txt b/Documentation/devicetree/bindings/sound/max9860.txt
new file mode 100644
index 000000000000..e0d4e95e31b3
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/max9860.txt
@@ -0,0 +1,28 @@ 
+MAX9860 Mono Audio Voice Codec
+
+Required properties:
+
+  - compatible : "maxim,max9860"
+
+  - reg : the I2C address of the device
+
+  - AVDD-supply, DVDD-supply and DVDDIO-supply : power supplies for
+    the device, as covered in bindings/regulator/regulator.txt
+
+  - clock-names : Required element: "mclk".
+
+  - clocks : A clock specifier for the clock connected as MCLK.
+
+Examples:
+
+	max9860: max9860@10 {
+		compatible = "maxim,max9860";
+		reg = <0x10>;
+
+		AVDD-supply = <&reg_1v8>;
+		DVDD-supply = <&reg_1v8>;
+		DVDDIO-supply = <&reg_3v0>;
+
+		clock-names = "mclk";
+		clocks = <&pck2>;
+	};