From patchwork Thu Jul 28 22:43:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolin Chen X-Patchwork-Id: 9251779 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 19FBB6075F for ; Thu, 28 Jul 2016 22:49:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A96827F60 for ; Thu, 28 Jul 2016 22:49:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F35E927F86; Thu, 28 Jul 2016 22:49:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D21A27F60 for ; Thu, 28 Jul 2016 22:49:55 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 8260426581E; Fri, 29 Jul 2016 00:49:54 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 46DE926656A; Fri, 29 Jul 2016 00:49:04 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id A234F26656D; Fri, 29 Jul 2016 00:49:02 +0200 (CEST) Received: from mail-pa0-f67.google.com (mail-pa0-f67.google.com [209.85.220.67]) by alsa0.perex.cz (Postfix) with ESMTP id 48F682655A5 for ; Fri, 29 Jul 2016 00:43:11 +0200 (CEST) Received: by mail-pa0-f67.google.com with SMTP id ez1so4152744pab.3 for ; Thu, 28 Jul 2016 15:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=P9vA0mq9MUh1A7JiQecRDZG+ltGo1uqe7lDvy7y75cw=; b=z9eC3WIc65cKTVcFUF4hluAAV6NhIzZkIQcghgsB1wc2F/uZWCUsYulQHswG8lsnXT Oz+9d7QLmd1PKWS0PLkDWY0kOj7U/HEYk550DgMJh5Qbj6EQX8rguVdE0vJMeSom0W8o k/BeDLdzKcWJRbMa9NbzmayW9sxDvfL56/VroSGceWV79Fipd6DBMu8Pm+MUg9GsyNqI x58wbp90gcxwSfr6Nb0inaunu2TpJJ1jk2aHGMB/jabxbCv6uCcF7lL2D/6fHTHfuLQm wHBUJ9bEpg2U7Qte/dyxXlDjZ3OhdmRl24Za4qs61q+kqvHXi6r+cgNM2o5yy1JJHH8g s8bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=P9vA0mq9MUh1A7JiQecRDZG+ltGo1uqe7lDvy7y75cw=; b=GuL5He5IB0OH7cfExIC03drWVmcG2DC2HG8BLL4GozhXLrOrxGwP4VDqnhy2+pOVK+ kLdtSGPeijjCMKjajuV4xV/gX+rVU/lYUiKwv4b29QGa5nScMiUFd73mjEDw8xG2aB0Y ErBN7j3RDgZg/s6cQNSr7UNC36ltXXx/bB2HAct5ygyiXN8UNJLQzJsWmmr1nniifRjY TAQQ2HMe56tQIe53S+YUo2WnoR8vMcNsBkcWMEIhBXRM5ggiY+i0cuSF0666j6A5Z+77 HlftRUoesJbDDBuqJoz6+lJ6VfyKVeIPCyDywBz/cREbZR617GK4+ZWUqAsB3cIwJxhB /nGA== X-Gm-Message-State: AEkoouvMJJ20WYJkriIengD3V86IwaSb75zYg/j7T+TyeMIXX/lnvvz0wHF2wlm/i6gixg== X-Received: by 10.67.22.137 with SMTP id hs9mr62839864pad.50.1469745790068; Thu, 28 Jul 2016 15:43:10 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id r10sm19478084pfk.84.2016.07.28.15.43.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 28 Jul 2016 15:43:09 -0700 (PDT) From: Nicolin Chen To: broonie@kernel.org Date: Thu, 28 Jul 2016 15:43:01 -0700 Message-Id: <1469745781-31057-1-git-send-email-nicoleotsuka@gmail.com> X-Mailer: git-send-email 2.1.4 Cc: brian.austin@cirrus.com, alsa-devel@alsa-project.org, lgirdwood@gmail.com, Paul.Handrigan@cirrus.com, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH] ASoC: cs53l30: Do not ignore errors if mclk is specified X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP When the clock is specified, there could be other errors besides the EPROBE_DEFER so don't ignore them. Signed-off-by: Nicolin Chen Acked-by: Paul Handrigan --- sound/soc/codecs/cs53l30.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c index 2c0d9c4..227c556 100644 --- a/sound/soc/codecs/cs53l30.c +++ b/sound/soc/codecs/cs53l30.c @@ -999,8 +999,8 @@ static int cs53l30_i2c_probe(struct i2c_client *client, /* Check if MCLK provided */ cs53l30->mclk = devm_clk_get(dev, "mclk"); if (IS_ERR(cs53l30->mclk)) { - if (PTR_ERR(cs53l30->mclk) == -EPROBE_DEFER) { - ret = -EPROBE_DEFER; + if (PTR_ERR(cs53l30->mclk) != -ENOENT) { + ret = PTR_ERR(cs53l30->mclk); goto error; } /* Otherwise mark the mclk pointer to NULL */