diff mbox

ASoC: Intel: Atom: Fix message handling during drop stream

Message ID 1472213717-19040-1-git-send-email-harshapriya.n@intel.com (mailing list archive)
State Accepted
Commit de34dcfe70576792a6312f9af4a1f880182b2d3b
Headers show

Commit Message

Harsha Priya Aug. 26, 2016, 12:15 p.m. UTC 
If a stream is being dropped, the period_elapsed received then after
need not be processed. Processing of the period_elapsed message causes
a time out in drop stream response processing. This patch adds a condition
to skip period_elapsed message processing if the stream is in INIT state.

Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
Signed-off-by: Naveen M <naveen.m@intel.com>
---
 sound/soc/intel/atom/sst/sst_ipc.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Vinod Koul Aug. 30, 2016, 3:53 p.m. UTC | #1 
On Fri, Aug 26, 2016 at 05:15:17AM -0700, Harsha Priya wrote:
> If a stream is being dropped, the period_elapsed received then after
> need not be processed. Processing of the period_elapsed message causes
> a time out in drop stream response processing. This patch adds a condition
> to skip period_elapsed message processing if the stream is in INIT state.

Acked-by: Vinod Koul <vinod.koul@intel.com>

Harsha,

Pls CC mainatiners, in this case CC Mark & Liam. They may not see this, so I
suggest reporting.
diff mbox

Patch

diff --git a/sound/soc/intel/atom/sst/sst_ipc.c b/sound/soc/intel/atom/sst/sst_ipc.c
index 8afa6fe..bfc8899 100644
--- a/sound/soc/intel/atom/sst/sst_ipc.c
+++ b/sound/soc/intel/atom/sst/sst_ipc.c
@@ -267,6 +267,9 @@  static void process_fw_async_msg(struct intel_sst_drv *sst_drv_ctx,
 				"Period elapsed rcvd for pipe id 0x%x\n",
 				pipe_id);
 			stream = &sst_drv_ctx->streams[str_id];
+			/* If stream is dropped, skip processing this message*/
+			if (stream->status == STREAM_INIT)
+				break;
 			if (stream->period_elapsed)
 				stream->period_elapsed(stream->pcm_substream);
 			if (stream->compr_cb)