From patchwork Tue Sep 27 08:30:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikita Yushchenko X-Patchwork-Id: 9351613 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 62280600CB for ; Tue, 27 Sep 2016 08:46:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5171928FED for ; Tue, 27 Sep 2016 08:46:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 461412910C; Tue, 27 Sep 2016 08:46:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7BB9028FED for ; Tue, 27 Sep 2016 08:46:45 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id ADC91266F1E; Tue, 27 Sep 2016 10:46:44 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 8C9F4266CB9; Tue, 27 Sep 2016 10:44:22 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 3C3E5266F0E; Tue, 27 Sep 2016 10:30:38 +0200 (CEST) Received: from mail-lf0-f47.google.com (mail-lf0-f47.google.com [209.85.215.47]) by alsa0.perex.cz (Postfix) with ESMTP id 348D1266CB9 for ; Tue, 27 Sep 2016 10:30:31 +0200 (CEST) Received: by mail-lf0-f47.google.com with SMTP id y6so14339490lff.1 for ; Tue, 27 Sep 2016 01:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=QrTd3uX6z5/w/L3F03fJgin2Crth3U0bbFYcMArvTcM=; b=u5KNRtVU5J29G0WZHMOJCSD3qfFUepHtB1BUPMZ90KykhMY9IxFuBDLV7E+NkjYaw3 rOj+TcviS1+vSG3eqLAlXwCsybPR3p/PL+N1gbyWXi4pf+4YV7DuOVZRwdmYKYTgagQ1 og/O3SuFyfqtgtEkjimFTVumv/HPhHZE3Hbokknmwd/SClEn0QxlkmUd0IgF0fUj/ZG3 6WONYfEuUliYQeoULtd+grrZDCkyQ/4k88mQWCFtpRyYWSmOI2IU/9V8KsnVhBjLCHhM ZddqaMmBWzYynzrqRjAVwu83TqDw72Kbu7IaiSkvyli0eycRZq3ukZQMGVCvFqO95T1o pXSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QrTd3uX6z5/w/L3F03fJgin2Crth3U0bbFYcMArvTcM=; b=fONZb1SNKWzXkSbhHUYbBwThCIQ09ZNw62rnht8XjHyZedTFSaOifpmprNdWnMO3WB KlD4b6j4sC/d1OMu5JzSvHJM9pFc+e7HpM0pyz+JMnpXABb8pc4+WbLiH0r3+PvtHrMb AONs+ibxAONaNF16rKUexRLwFmGZue8AslNZieiwV3P5BEglaO2MV710oRVoA1qp9xEG +MJ3cO7SP3X+DwjbG5kG4XwkQA7byFa/TzQMEi2gT36jCevNfMCCmC6UC21fff7QWA0X SAxiUKOZUw4/V+eQNlU23HYIz64xmcNgrlssiMOH8hEhwjKCx2Y2FnNfsVlwZFqSlIjS dDrA== X-Gm-Message-State: AA6/9RlppHFE5h3dIxnPQo5Ny+wAwe2aZB4humEnwMA9iLfNsMR+YbuJWZsm1mVZvyJTBg== X-Received: by 10.25.32.15 with SMTP id g15mr2245374lfg.165.1474965030811; Tue, 27 Sep 2016 01:30:30 -0700 (PDT) Received: from hugenb.home (nikaet.starlink.ru. [94.141.168.29]) by smtp.gmail.com with ESMTPSA id 184sm222260lfz.22.2016.09.27.01.30.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Sep 2016 01:30:30 -0700 (PDT) From: Nikita Yushchenko To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Bastien Nocera , Kuninori Morimoto , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Tue, 27 Sep 2016 11:30:15 +0300 Message-Id: <1474965015-29243-1-git-send-email-nikita.yoush@cogentembedded.com> X-Mailer: git-send-email 2.1.4 Cc: Nikita Yushchenko , Chris Healy Subject: [alsa-devel] [PATCH] ASoC: tlv320aic31xx: do not declare support for mono DAI X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This hardware supports only 2-channel DAI, even mono ADC digital output has two channels with the same data. Having min_channels=1 results in broken playback of mono files in setups where CPU DAI supports mono. Signed-off-by: Nikita Yushchenko --- sound/soc/codecs/tlv320aic31xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c index 725173b12725..be1a64bfd320 100644 --- a/sound/soc/codecs/tlv320aic31xx.c +++ b/sound/soc/codecs/tlv320aic31xx.c @@ -1213,7 +1213,7 @@ static struct snd_soc_dai_driver dac31xx_dai_driver[] = { .name = "tlv32dac31xx-hifi", .playback = { .stream_name = "Playback", - .channels_min = 1, + .channels_min = 2, .channels_max = 2, .rates = AIC31XX_RATES, .formats = AIC31XX_FORMATS, @@ -1228,14 +1228,14 @@ static struct snd_soc_dai_driver aic31xx_dai_driver[] = { .name = "tlv320aic31xx-hifi", .playback = { .stream_name = "Playback", - .channels_min = 1, + .channels_min = 2, .channels_max = 2, .rates = AIC31XX_RATES, .formats = AIC31XX_FORMATS, }, .capture = { .stream_name = "Capture", - .channels_min = 1, + .channels_min = 2, .channels_max = 2, .rates = AIC31XX_RATES, .formats = AIC31XX_FORMATS,