From patchwork Wed Apr 5 19:44:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 9665545 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 35BE4602B5 for ; Wed, 5 Apr 2017 19:45:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22CE6281AA for ; Wed, 5 Apr 2017 19:45:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1324B2856A; Wed, 5 Apr 2017 19:45:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C27D281AA for ; Wed, 5 Apr 2017 19:45:04 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id F1F6C266C1E; Wed, 5 Apr 2017 21:45:02 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7FDD52671DC; Wed, 5 Apr 2017 21:45:02 +0200 (CEST) Received: from mail-qk0-f194.google.com (mail-qk0-f194.google.com [209.85.220.194]) by alsa0.perex.cz (Postfix) with ESMTP id 76F5D266943 for ; Wed, 5 Apr 2017 21:44:57 +0200 (CEST) Received: by mail-qk0-f194.google.com with SMTP id p22so3093452qka.0 for ; Wed, 05 Apr 2017 12:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=HqVcgnporKRkwxBGBQouU8vvJG3IkvoSpbhk/6TlXBg=; b=vPSpRpXCqqQcEKIW8XvSwZ+MDCxHQ3ljmGy+fumlT7jCYx3bWZpY9KvxfRdZI3KUUv iDgkSboJz9jDoNg6oR2a7FbtRUmV6qlv/hQ+6lwql8qL7BNxe7Oe+GyheF9tCqlrI9ZX k3nu/OW/6YSTw89CDiQQOO6wUDDiJIMVggGw3omNxRKsTa/rLD0tlJf3L1QL/uxWRSQB rPJ4zcSLXHDlxNZp7EPv1ByxGzeccY3dJAsn8/DeJuPzK7Jf5UEwH0kG14N1HBTMqUIK RHIhWGLkG7u1dT10PQJbEKxzIirA5GTBRwqWVIFrY/jz7nzOmfJ6lisP50s8FOMPbyjk 75Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HqVcgnporKRkwxBGBQouU8vvJG3IkvoSpbhk/6TlXBg=; b=ol7HaH2FDYxo0fd/HIhepkUmO7PH8OHWM2hvNj+GVz1Ab6Z4BFTuIbJ+klY7UNHxvs bcXKStcGFs+fLachRBgLFlaL63pmMaCM7R02utyLTeu+fgF3X+35EMwSMBTNJPV6ybrs IYRTqTWFZyA0+xBBDRnQic55J47xrXh+XYwxr1KT8HvIaeKnPP57A9kVSCHwlmaWIhKU vgtiH5W0nO91rvtbSc8zE2xcY4VwNkZXh3/q1eOvjrKnm+M0TD8FMCySdVRch4FSy3W4 VUueo6DIwKqzcPfZEJR+iXk2wk4RfXxc9IuJvzNGjH3q+xFqjdu7o3UA8DtnYMOrmRob ZNOg== X-Gm-Message-State: AFeK/H0PtWf6c9aVFi6tabROngEgxaVFMUEEwPMSywm/a/W746AHl2gxMI2BKewXnmC87g== X-Received: by 10.55.136.2 with SMTP id k2mr30770336qkd.316.1491421496982; Wed, 05 Apr 2017 12:44:56 -0700 (PDT) Received: from localhost.localdomain ([189.61.213.245]) by smtp.gmail.com with ESMTPSA id k133sm7941591qke.25.2017.04.05.12.44.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 05 Apr 2017 12:44:56 -0700 (PDT) From: Fabio Estevam To: broonie@kernel.org Date: Wed, 5 Apr 2017 16:44:05 -0300 Message-Id: <1491421446-13799-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 Cc: nicoleotsuka@gmail.com, Fabio Estevam , alsa-devel@alsa-project.org, timur@tabi.org Subject: [alsa-devel] [PATCH v3 1/2] ASoC: fsl_ssi: Remove FSLSSI_I2S_RATES definition X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam The comment for the FSLSSI_I2S_RATES definition states that the driver currently only supports I2S slave mode, which is no longer correct. As FSLSSI_I2S_RATES is the same as the standard SNDRV_PCM_RATE_CONTINUOUS, just remove its definition and its comments to make the code simpler. Signed-off-by: Fabio Estevam --- Chnages since v1: - Simply remove FSLSSI_I2S_RATES sound/soc/fsl/fsl_ssi.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index fde08660..0b74d1c 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -55,16 +55,6 @@ #include "imx-pcm.h" /** - * FSLSSI_I2S_RATES: sample rates supported by the I2S - * - * This driver currently only supports the SSI running in I2S slave mode, - * which means the codec determines the sample rate. Therefore, we tell - * ALSA that we support all rates and let the codec driver decide what rates - * are really supported. - */ -#define FSLSSI_I2S_RATES SNDRV_PCM_RATE_CONTINUOUS - -/** * FSLSSI_I2S_FORMATS: audio formats supported by the SSI * * The SSI has a limitation in that the samples must be in the same byte @@ -1212,14 +1202,14 @@ static struct snd_soc_dai_driver fsl_ssi_dai_template = { .stream_name = "CPU-Playback", .channels_min = 1, .channels_max = 32, - .rates = FSLSSI_I2S_RATES, + .rates = SNDRV_PCM_RATE_CONTINUOUS, .formats = FSLSSI_I2S_FORMATS, }, .capture = { .stream_name = "CPU-Capture", .channels_min = 1, .channels_max = 32, - .rates = FSLSSI_I2S_RATES, + .rates = SNDRV_PCM_RATE_CONTINUOUS, .formats = FSLSSI_I2S_FORMATS, }, .ops = &fsl_ssi_dai_ops,