From patchwork Fri Apr 7 12:14:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 9669381 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5C1B9602B3 for ; Fri, 7 Apr 2017 12:16:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4B11A2832D for ; Fri, 7 Apr 2017 12:16:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3E05628489; Fri, 7 Apr 2017 12:16:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C4292832D for ; Fri, 7 Apr 2017 12:16:47 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 88EA82673A4; Fri, 7 Apr 2017 14:16:45 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 24AC62673A4; Fri, 7 Apr 2017 14:16:43 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0041.outbound.protection.outlook.com [104.47.2.41]) by alsa0.perex.cz (Postfix) with ESMTP id A3D0C2673B7 for ; Fri, 7 Apr 2017 14:14:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Hnek7v09JGSeYK7s2lThDs5Dvuc7V5iycwISJX6iU9c=; b=Z8/1q7Kpeyx1da5T9DFWK5NmqtgyEZmCbbtKU1Xsq/duMTqJRjPBZPqZkfjxTGyfqIG3vbIQw8+NJiLLeIZo39EGjdPVTV1Fz4MkgNskmdGMwvRYRSaNXVmxpXo2c4lEhSoPdGtHKSj8sOQHekMACiCsVwi7dS+GO2MTRgYWZN0= Authentication-Results: suse.de; dkim=none (message not signed) header.d=none;suse.de; dmarc=none action=none header.from=nxp.com; Received: from fsr-ub1664-118.ea.freescale.net (192.88.146.1) by AMSPR04MB501.eurprd04.prod.outlook.com (2a01:111:e400:803a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17; Fri, 7 Apr 2017 12:14:52 +0000 From: Daniel Baluta To: Date: Fri, 7 Apr 2017 15:14:40 +0300 Message-ID: <1491567280-20273-1-git-send-email-daniel.baluta@nxp.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [192.88.146.1] X-ClientProxiedBy: HE1P18901CA0020.EURP189.PROD.OUTLOOK.COM (2603:10a6:3:8b::30) To AMSPR04MB501.eurprd04.prod.outlook.com (2a01:111:e400:803a::16) X-MS-Office365-Filtering-Correlation-Id: a7031a56-385e-49e1-8971-08d47dafb263 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:AMSPR04MB501; X-Microsoft-Exchange-Diagnostics: 1; AMSPR04MB501; 3:nBbusKupUL42gvXt/iTCeNh8ebnq1474m7Ok7pcxbhqIP9yqS+Yu/jg1O8zyMLl06Gs1U0SURpkEr0C4n1PKq1ow6C6BJI39r3RyR3T4Q7wW7rGBz3yBqAzy/KZw/dPRE0WM/lxsvlKUI3Gi1riNH3Rric683iBSw1ZfWwCMZrwZNTeynvJcP84BazkurP6BVH1ATYkUht95nb2ImZhiMxVohtNk4JRy8iQeOdw8Wi/S6IYMSJMPLa84dl1lY/odvC53eXDMjE3WPdiQ5W+edRSjWd2y1oys82SsBR45j09htSTKwq+LE4TBJGFpNknXHDEckxqZxM3HbUhWSz+vtaGQAsWpWctCkOu6xAJL4cI=; 25:BEbPBTGlpecZ3q+AjBrts8rKVrv5dXtH6KTK8TJZHHrDNlt1DkG2201zDa5IF67nu1QtCo3nPiTMDJRfdnw3PGzkGOyUKQi5b/leyY1LhKTu5iNjx8JBUOB6ojgPgOT6hajpgjptwIkAvmvQXbTsC/c8rC02xwJiMwD4O0uu+afSmkkAhfEqeqJ6pj43ykMbBc+9lRbs6U74O/EAFIVYG7trm+j85+VB5+DhAppYfm/pC20gcOahIeArLrdx144gTl+8rFVrBsmgSyEJfAyqiC8CD7OTVb3jHKsfwDJASvtGXPlS8xjL+3xI23f9+K2KQ5xMSZIHYjzq6o290kxup6deteKv/eXnULAVDBX9xsbcrp2mk8CX9j8raGCxbhSQfZBgbuakvOb5yew52ADiv7bjKj9lMHfCwjsFxwkjSL+kE/4r8Dh5kfThrowoVmpsy26USkuja7u1dbNkYQGV+w== X-Microsoft-Exchange-Diagnostics: 1; AMSPR04MB501; 31:27pf8T/XlwqyR0uU/jlhpTlUTO+1pJZ+TCHlh5BEtFVCwQZvxGeXfRmh4Tn0cIsSZJoSEkxQ10LyGA5KBefDLE9hkr/85VqXR9o6rtU9XMtT+/M0UnwVqscGrj+5QztcS5B0O7w/fL9ZTYeez36icR8LmoEpoOgAt0eApBE6Er7AaEq81BPDZA+IyAwTlx320UrZQvqwRgUlVYgsbObdcw7mYn3L6mfyfEZoaGvfwiPo9irnylT7vtcCl1jPlJVt; 20:Kon+1kmK81LigOS02JZfu4P0rQJu2kwLCVkXCvUe8yY4//GK/5FUqgamZ1h6uWZsWzMu4cTn/0HdR4MR7YbblBMkO1os+7wz8y1iodhnxDPztXXuTLYg5h+fZdIIKdsrSvXJ9D7Pacj8z3If/78FhiBdnPBGk9XQ3WGdjshxra+8QEfUgDPwW99y0vsX26jH+Npg7ROrGcbTzHmGiUm/Wi6Mpihuuhy1gaQztsAhP6seMDX7sBag0iEoZRf0n3kQjOZkLV734GUP9u/lxe3oJyn67KTTLiiCPWnpHBMcWVTgf5I25myKbw3OFg4Qb8XI9p6lSR6bIUFm79h9uU2tScWfZaZSA17ld+GIm8VfHb8f7hqpixkqK0ObO1oLgARjW3tGkAFwrKG7nO6q3Ei4zS9nGp6m6RV5qt+fe+7EY+OaWL/k8GvJkACtO01+EcGDTTRZcdIFdgQHSag20g4MmkIZGWaw2CNsmOrf0/RiIShgSAmxqgkaxcRcRzJK9s62 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148); SRVR:AMSPR04MB501; BCL:0; PCL:0; RULEID:; SRVR:AMSPR04MB501; X-Microsoft-Exchange-Diagnostics: 1; AMSPR04MB501; 4:4YOU4xsBsqJgHjaCqcrZaLK+CxDWZvLXwhSKd453v5gxqzN2pw2KtdFp0zV+9rrn0jVVKDkdgxYHXtegTTYFr5LX5T7Aph43wG0ijvHRLAm12MShWq9aWGuQzP4NTGeyvDnU4myK+p4NAB8yccuZ65/Zs56LFPpCh/Ep/pSeVWUQSgTqYD4o2o3suJBDC9+lwCc02lDKNhe5OqRgfvqR/eW+KabDPNGPbl/fGJ/qQMVmcTXFqgy5EndKGKB3KQmL5qMFQ7QkC1bkHz4DQzjqRMqNc4ZoqYHy0BDpmcLLxOCsz8kbfn/3R6b14TCLEEG5bmow8s6HbDKnMJZEo9/lOkNy+XZ0qqqkV6eHJo3Criqnk/0L+hTo0e8Uhef74M8wZlBQfsIYUR7mP7FXHsklLvbI3i9E1kimyN0/w2qNT+tGUZn+Q1LPbgOkj/652DUssrq6yCOxbrrHtREztqGwgHxMBXvvksINRc7ldq/E32ZxjTEeYHyLx7m2Eh+Ml0LLxFwLewx00n6kqxpabOKpM+04SVUioOg78hvmG8yNE3BXFmjg0HtmPjsmxjiiyEZu0oTilwD48cbCCu7XnO/srr3P1cv+4Vcwzjth6xc1WqUpIxRoqbgAVbfYT1ro1R2/bbUCsvMzX1I5XDEY+u5dRrubR+Pu6D8Su4fCIDf3ZJBjCLtwNu+8/OnGIB93EDW/7HaYYd00FYj7QKZvtzrRqVyn5xpvRwLSVw0/7G7+aPSbVq5WQJ8lblme5DdTh7ii3gj1BS/Nvx6ACTIhe+pcxQ== X-Forefront-PRVS: 0270ED2845 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39850400002)(39410400002)(39400400002)(39450400003)(39840400002)(39860400002)(6116002)(86362001)(3846002)(6486002)(2351001)(6506006)(42186005)(81166006)(50226002)(6916009)(6666003)(36756003)(33646002)(8676002)(110136004)(50466002)(47776003)(5660300001)(38730400002)(2906002)(305945005)(48376002)(5003940100001)(25786009)(15650500001)(50986999)(4326008)(66066001)(189998001)(6512007)(54906002)(7736002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR04MB501; H:fsr-ub1664-118.ea.freescale.net; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AMSPR04MB501; 23:wnAaHnZOkixoikQ0icjJ/Ip/gshD7LIRsFibr8JB9t?= =?us-ascii?Q?tZzgUcelUwlrJGF3p7KvXHd/M6fb1Nx1whQLXNlwsjDNxwzrGrcn/3qpUrSx?= =?us-ascii?Q?m2NVq4uH+7+/jsjs+7JtF5gQncwu1sN0yQYHlvF0CJc5wswen6o0P1LHcV2M?= =?us-ascii?Q?JR83wuVbMqzU+MeaU149OQ7+YHcqZNFU97W4JRxWmbecvKv8oL1rnzXQqqmp?= =?us-ascii?Q?+fieSywACmsjWohyvSm+GaBc3FgxvJKwNikj9ZPBAUfwgg7auBzqGyGnqwq7?= =?us-ascii?Q?L9eDcunVm0TuiLvXx0jFJim3kof9tUcbP2+GDjMDpj7X116XSL7bS2+qsJDQ?= =?us-ascii?Q?nzcAp0EXcwjmnn910n5i0ICIPdyEHEur0bedEdGomQqGWzHAuqS2cIxU69bf?= =?us-ascii?Q?QxEXjLzTH+JBQtZUgfAeZjyGXn3kaosfk+lz4w0uOwUzUaZRBNSoG3jK9/kK?= =?us-ascii?Q?o5euD+LxyaH9rg4A/DqR/KuwnEr47jazm8NT+NiYel1yyc7S4N5UwGB2fxeB?= =?us-ascii?Q?BnIyAQwfUgoqevoSEgGonsagFD1qlajVZOuZaity0bd7d4LSZdnVCWntAl4v?= =?us-ascii?Q?fqf5EIJAD0oHaxm0/wotbOpU0JXLkLwd+AQ9nbklAuLIxsqf0I6iNMwZTGTj?= =?us-ascii?Q?hJoAy7sRK4Y0Mnpq3BSRQk7hYYRkjaRsZtyVjG7HaE2lIgBMI6RUGMOjeRd+?= =?us-ascii?Q?DcuKdjffNCFuU6v3NFoSoD6A1LSCDf1Tr9IQ+jNw85gbjngINKMg+pAxJvUa?= =?us-ascii?Q?vkWXNUmgPUySTIPu2iTjorTgDZNifa9Q0BzAbKaBgG8gS//i/1CTpqKTTnr+?= =?us-ascii?Q?PKiVsC2GtAFB+gqEX4/rstxyneqSZoHyHZ5S2bN43IwVnZaGGyDFhJToRSJh?= =?us-ascii?Q?UUjNFV82qKpG+gHH4QGyV7MlJbV7g1r9jDOB7Te0S59YS9SoHD1VadqGJBHs?= =?us-ascii?Q?cvgCXM5u7s6gAZl9sVJNYe+XySQ8KQ3VhOOJs5ttRc8JZ7jNa21iWsdBOnbX?= =?us-ascii?Q?5S6f5lrlM5xsUnuumPpGZgkwmhKqxyco+mYtMXQ71ECQoo19LiOk6Bgd9qAn?= =?us-ascii?Q?wuHXs=3D?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR04MB501; 6:3u1szimnY+DAcyRquq/oUpSPcHtODC0G5Kw1A7ftykg6AE5XQ6NFab5My9LeX9oc06xk76ZQEIkaslh/FiksCUDdzHeWO83RrNRpqLqv2YrYnfTJi8sZ8e/HX7zAEH8XDhgIRkwu3l1me5VnBk94JRV7to4hdcndQdHaLcXjTvAF5Gmq6Lvtxt5PNgxH2rJj42752y3SMnBI/c9b9ZovbiOoSZZFLO8ckWdjYqygw3gkmF2+Icd2aZYlfs09IVF2ZCrhysJXbhtG1Mf18K51wgjcei0PBM2Y3XRy8K3rbQMLVptMVc+ujTIJinsVPvICLjXnXtvGoYd6nfppeBENidJcXk4xocH5GOSjau02WYPFsKJNhwiPYWj6J/j/j1wfHpiGhVllSw6pPeRAcx2hEDTR6srlr1us3amZ2aw1RVkeTCSeO8PVGLt45ZcqhCQ8KAjFp/c2smSSioBZVhttsb3nEhopBju/7F19/920WNA=; 5:DKx72R0qTpneJjHwNe6VGBMqAKymjCCmimh4pWO3AJ1yVkYX1+mLIiafT0UKWDUHUaNVobtRoXR1k2UGKPZfnBntZFCX3OS37wogbYVVnWQWKr6hmGW52AkFonUQLo6Vb3N7gjJX9qvq4+5o+ZgpIA==; 24:PnJh/5zbD+NjYifiN7nIXnmr/zku2ZuaCs0BhuiDZ55oXnxhkR+cPCaCvCKKkEz8O+r5BGXVu4QK1Tng8TXQIT8fgh5gFwFnTOrk91N43Jw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AMSPR04MB501; 7:qQpoYZ3pvNu2EG8FolO1ACxs0kGAeDgWEdpqWZwzUijPvX9eBYfw6qpk5yQ5g2sZECA3YfoRac5kzsMxA1qe01aM/N6CruiY95zUI+VBLGf7vxPaZiwO+VzitX/LTyF+nBB3Y4Px6zz5cEZu0XKyvRx9Ngrg2UCQmlSdgRBrMLt0imBwNiMbkKHJW1jb/j3264xt8bXisvhT4Hg5F9j8fPFAswoKmbDer5gN6AXuYRuXUk2XF4LYKR/X7rg/ZyGVIdPx7JgcDoWRq5q67Jv48JrI/hzZrzg6qnxPEtH6R1bPTT1QyLBZ05+mqqXI/f0tV9r6IGqEZXR+1R82CUTSVQ== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2017 12:14:52.3573 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR04MB501 Cc: mihai.serban@nxp.com, alsa-devel@alsa-project.org, broonie@kernel.org, shengjiu.wang@nxp.com, viorel.suman@nxp.com Subject: [alsa-devel] [PATCH] aplay: Fix error message when writing captured data X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Write can return less then requested bytes, but we treat this as an error. Anyhow, errno is not updated in this case and we can end up with a confusing error message. For example, when there is no room to write data into the output file we receive: $ arecord -d 2000 -c 2 -r 192000 -f S16_LE -Dplughw:0,0 audio.wav Recording WAVE '/mnt/msc/audio.wav' : Signed 16 bit Little Endian, Rate 192000 Hz, Stereo audio.wav: No such file or directory Signed-off-by: Daniel Baluta --- aplay/aplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aplay/aplay.c b/aplay/aplay.c index ee480f2..9547d1b 100644 --- a/aplay/aplay.c +++ b/aplay/aplay.c @@ -3079,7 +3079,7 @@ static void capture(char *orig_name) break; } if (write(fd, audiobuf, c) != c) { - perror(name); + fprintf(stderr, "Couldn't write all data to %s\n", name); in_aborting = 1; break; }