From patchwork Mon May 15 08:19:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 9726347 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A7FA2601E7 for ; Mon, 15 May 2017 08:19:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 94E8A2896B for ; Mon, 15 May 2017 08:19:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 86A6B28970; Mon, 15 May 2017 08:19:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 72E9A2896B for ; Mon, 15 May 2017 08:19:20 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 5FA1F2672BC; Mon, 15 May 2017 10:19:19 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9CE4D267332; Mon, 15 May 2017 10:19:18 +0200 (CEST) Received: from andre.telenet-ops.be (andre.telenet-ops.be [195.130.132.53]) by alsa0.perex.cz (Postfix) with ESMTP id 9FC482672BC for ; Mon, 15 May 2017 10:19:13 +0200 (CEST) Received: from ayla.of.borg ([84.193.137.253]) by andre.telenet-ops.be with bizsmtp id LYKC1v00Z5UCtCs01YKCjm; Mon, 15 May 2017 10:19:13 +0200 Received: from ramsan.of.borg ([192.168.97.29] helo=ramsan) by ayla.of.borg with esmtp (Exim 4.86_2) (envelope-from ) id 1dABDk-0007Y6-KF; Mon, 15 May 2017 10:19:12 +0200 Received: from geert by ramsan with local (Exim 4.86_2) (envelope-from ) id 1dABDk-0007V8-JE; Mon, 15 May 2017 10:19:12 +0200 From: Geert Uytterhoeven To: Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Takashi Sakamoto Date: Mon, 15 May 2017 10:19:10 +0200 Message-Id: <1494836350-28790-2-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1494836350-28790-1-git-send-email-geert@linux-m68k.org> References: <1494836350-28790-1-git-send-email-geert@linux-m68k.org> Cc: alsa-devel@alsa-project.org, Geert Uytterhoeven , linux-kernel@vger.kernel.org, Arnd Bergmann Subject: [alsa-devel] [PATCH 2/2] ALSA: firewire-tascam: Use do { } while for loops executed at least once X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP If a loop is intended to be executed at least once, it is better to use "do { ... } while (...)" instead of "while (...) { ... }". The former is easier to understand for the casual reviewer, and doesn't require preinitializing the canary variable. Signed-off-by: Geert Uytterhoeven --- Compile-tested only. --- sound/firewire/tascam/tascam-stream.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/firewire/tascam/tascam-stream.c b/sound/firewire/tascam/tascam-stream.c index e433b92ac6904db5..4ea6845aae87fdef 100644 --- a/sound/firewire/tascam/tascam-stream.c +++ b/sound/firewire/tascam/tascam-stream.c @@ -80,17 +80,17 @@ static int set_clock(struct snd_tscm *tscm, unsigned int rate, int snd_tscm_stream_get_rate(struct snd_tscm *tscm, unsigned int *rate) { - u32 data = 0x0; unsigned int trials = 0; + u32 data; int err; - while (data == 0x0 && trials++ < 5) { + do { err = get_clock(tscm, &data); if (err < 0) return err; data = (data & 0xff000000) >> 24; - } + } while (data == 0x0 && ++trials < 5); /* Check base rate. */ if ((data & 0x0f) == 0x01)