From patchwork Sun Aug 20 05:21:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donglin Peng X-Patchwork-Id: 9910937 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4CC1F602B1 for ; Sun, 20 Aug 2017 05:31:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E62D2873F for ; Sun, 20 Aug 2017 05:31:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3289D28781; Sun, 20 Aug 2017 05:31:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 95B622873F for ; Sun, 20 Aug 2017 05:31:26 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 0E01A267354; Sun, 20 Aug 2017 07:22:01 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 32B6F267354; Sun, 20 Aug 2017 07:22:00 +0200 (CEST) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by alsa0.perex.cz (Postfix) with ESMTP id 804A626737C for ; Sun, 20 Aug 2017 07:21:40 +0200 (CEST) Received: by mail-pf0-f195.google.com with SMTP id w127so14581pfd.1 for ; Sat, 19 Aug 2017 22:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=1gjsYLP3rg/Sd4eW2HhA9XwALcj7CIA+z5Xbl0HVFfs=; b=l7pUw5RcsP6HC6DOSc+PRu/45KFg1bWNtcu/anBtmW3wjAHiW4x8yaoQ5Q90k0NwEq qt4/ee86XcwiWA1zPcqOw0Dd7xqcRWxmPtiDlFIOY4EiZ06yXDHOqP1WsHnaKhrLTX+0 Uo5hjImXPARscUyVQzwwOG/MlZY9SbJcin457waWeRbtMMIs2mJARREekjRr6/q6y9NM nqBPr1AShj6DbeitpWCpoq7d0RYvhi16SXn4Qv4DotmnvS8b8Y4uQULCYfBOvQEC3tzL JAczf3+6LaRJCQ6oUyQaa77qfeCN7dBk2ZGKaIOG01JHfuYbZjaGjN1ugJnBx0h93WRB LJJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1gjsYLP3rg/Sd4eW2HhA9XwALcj7CIA+z5Xbl0HVFfs=; b=H4JcCyWcp5gD2kULmpTASFxpVrExgWFLEu0T+oGkCSJK/OqVP4rHEHMjB+9nPLNyS9 h7Q3RDXkM9FcuGi8muCkSkUk0GsLNIDKKimcPeSedmfTDcRn75+9Osei6A5qjclGebof z0y8Ml8DyRj965f8ZTsZfvRyCLvOQNT1gyTgUQEH0EEgZ8hPti6sSshxcC39vXvXVYuf gWV10UBAZq+htBFeeG3ptAuX+2MnY+MdhXWmn2SY3bIvOU4dUi1wclWGgPRdVsr2FOV4 26ox8gdwtsLyRiEHYNog0/Rep4AlaBKgfQdTVZANUB4xip/t5RCiI+Ny7tj5DIlWeW5X DI5w== X-Gm-Message-State: AHYfb5gCm4nATNjWdj5bvd3BR8A1iiS0kS6Hwo2EomjutD+IT/LmK3KW 2586QEdEg1nMDg== X-Received: by 10.99.98.69 with SMTP id w66mr12849529pgb.58.1503206500065; Sat, 19 Aug 2017 22:21:40 -0700 (PDT) Received: from localhost ([114.244.74.101]) by smtp.gmail.com with ESMTPSA id 77sm549296pfz.47.2017.08.19.22.21.38 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 19 Aug 2017 22:21:39 -0700 (PDT) From: Peng Donglin To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, krzk@kernel.org, sbkim73@samsung.com, s.nawrocki@samsung.com Date: Sun, 20 Aug 2017 13:21:35 +0800 Message-Id: <1503206495-14948-1-git-send-email-dolinux.peng@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Peng Donglin Subject: [alsa-devel] [PATCH 01/12] ASoC: s3c24xx_uda134x: Remove unnecessary function call X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP First of all,the address of pdev->dev is assigned to card->dev,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin --- sound/soc/samsung/s3c24xx_uda134x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/samsung/s3c24xx_uda134x.c b/sound/soc/samsung/s3c24xx_uda134x.c index 55538e3..758e46e 100644 --- a/sound/soc/samsung/s3c24xx_uda134x.c +++ b/sound/soc/samsung/s3c24xx_uda134x.c @@ -237,7 +237,6 @@ static int s3c24xx_uda134x_probe(struct platform_device *pdev) mutex_init(&priv->clk_lock); card->dev = &pdev->dev; - platform_set_drvdata(pdev, card); snd_soc_card_set_drvdata(card, priv); ret = devm_snd_soc_register_card(&pdev->dev, card);