From patchwork Sun Aug 20 05:25:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donglin Peng X-Patchwork-Id: 9910931 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 930E2603F9 for ; Sun, 20 Aug 2017 05:31:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 840C028785 for ; Sun, 20 Aug 2017 05:31:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 78B6A28905; Sun, 20 Aug 2017 05:31:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A013828781 for ; Sun, 20 Aug 2017 05:31:25 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id BB79026738D; Sun, 20 Aug 2017 07:25:34 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 189BF26739D; Sun, 20 Aug 2017 07:25:33 +0200 (CEST) Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by alsa0.perex.cz (Postfix) with ESMTP id F11C2266BCF for ; Sun, 20 Aug 2017 07:25:30 +0200 (CEST) Received: by mail-pg0-f65.google.com with SMTP id 83so19543031pgb.4 for ; Sat, 19 Aug 2017 22:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=rmjBssWYLlkb5fpx0+vq8kSqu5EUzvqM+Sj0rmKx5LI=; b=ontOhh+pSuGo9/2usijYK2/0/Aks2qI2xpF9jRQk05k7/Lf10owA6WKDXKWimyObmf NMD53Zv6x3VLtYTmkGkEFUHm9seggzZaGZsDvx6gASqli6AJQ0gdC6HCR1/PxzTAihB0 mxN4mvo7iWqPJgsIbABopfHAieBHxog5zerc4A+Vj0BI3jPF/0xVfbtILsC8a8i2GKH1 zQ3ztMHyaCQZZccVPDUGvU2+XQ5x0pUbyicnXb8s+drU2yVzYqyPO1itROZsKvbt3Lpr h+jU2tlmky68BrWGp+YMv+ZF7qTUs1Huizb3gH1cpb7phrxb6nlTjPfoKIjjB1GknXtm ycPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rmjBssWYLlkb5fpx0+vq8kSqu5EUzvqM+Sj0rmKx5LI=; b=gexBaDGBB+ZNCdGJQHaZ6g6iCgDmBONeaoBvXiMPiix7QzW86XOLvnEc6yWFDlTmQ4 rC8f5BVpyuNd7HPgSAMQh7xB/fhSYJE6z4MzemMDwojKjI7LnxKOySbcM6r4uv2vibs4 7lS2vN6BJoQg2NrJt2e5P/B1KIie1G2xArPR4omNLnuipV3BnwK6GIWNSZb+4DObMO8d biuwDl6n1+L/iseLCa7DZZUBExut9NDNcWxPVltnpGMc+5buNyJmcC0WdzmVMDUSg/oe bQk3bZEXCTiLdh5FAxR/AbpQl/G9ksQSdLzPJNBwWTNH1UCgliU8TinuWeG+IDanUoP0 OhSw== X-Gm-Message-State: AHYfb5h2fsEB2nsqSK3JF6QU+Eb6ADspJfe4PjburkpIL/C0xcxBs4Os vpfBVMapmKWP3w== X-Received: by 10.84.213.2 with SMTP id f2mr15237531pli.192.1503206729958; Sat, 19 Aug 2017 22:25:29 -0700 (PDT) Received: from localhost ([222.131.239.182]) by smtp.gmail.com with ESMTPSA id d5sm17778346pfc.110.2017.08.19.22.25.28 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 19 Aug 2017 22:25:29 -0700 (PDT) From: Peng Donglin To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, nicolas.ferre@microchip.com Date: Sun, 20 Aug 2017 13:25:25 +0800 Message-Id: <1503206725-15454-1-git-send-email-dolinux.peng@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Peng Donglin Subject: [alsa-devel] [PATCH 05/12] ASoC: atmel: Remove unnecessary function call X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The function platform_set_drvdata copies the value the variable card to card->dev->driver_data, then the address of &pdev->dev is assigned to card->dev in atmel_pdmic_asoc_card_init, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will do the same copy operation, so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin --- sound/soc/atmel/atmel-pdmic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/atmel/atmel-pdmic.c b/sound/soc/atmel/atmel-pdmic.c index c917df7..8e3d34b 100644 --- a/sound/soc/atmel/atmel-pdmic.c +++ b/sound/soc/atmel/atmel-pdmic.c @@ -694,7 +694,6 @@ static int atmel_pdmic_probe(struct platform_device *pdev) } snd_soc_card_set_drvdata(card, dd); - platform_set_drvdata(pdev, card); ret = atmel_pdmic_asoc_card_init(dev, card); if (ret) {