From patchwork Sun Aug 20 05:26:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donglin Peng X-Patchwork-Id: 9910921 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1A48560382 for ; Sun, 20 Aug 2017 05:26:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0C3FF286F5 for ; Sun, 20 Aug 2017 05:26:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0104528781; Sun, 20 Aug 2017 05:26:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56360286F5 for ; Sun, 20 Aug 2017 05:26:38 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 41A65267393; Sun, 20 Aug 2017 07:26:36 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id A2EBF267393; Sun, 20 Aug 2017 07:26:34 +0200 (CEST) Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by alsa0.perex.cz (Postfix) with ESMTP id 24E3B2673A0 for ; Sun, 20 Aug 2017 07:26:31 +0200 (CEST) Received: by mail-pg0-f68.google.com with SMTP id 83so19544209pgb.4 for ; Sat, 19 Aug 2017 22:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Q0ioskUlH/N4P5a5mlidjNd8QrxmSlfE3MMsISu8Kz0=; b=jF1w8LHG44k4YdH3h7n25RFbaXFdgvBxnVc9pWt/Ar6n0N9pt7B56/luD3wTMWxS6r fYwG5gdaqkWQZ5HDUibLCTB3z8DfPGneUWFcfYRWkohZh0kMrtg35Hw9T9cpFxpkX7Mq JH0qplBn12pGNrwK919UHZwCOGXgrVFzrfmLTbC56IUyYea2F8bDdM8zpx4pyLEohxqf dKS92OH7aFdpU8ql4MeqU9pWSZ2p7P5F8WFF7L6Y04bYfY35oBoAKwYfEsG2IAYTx+Bo 6d29+ZedMaP0ViKDW9iE00T3YTYmWrrcO8xeofdGIE6OrCU9ZzrWNvNl8TCj8VBr1tjR 3ZDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Q0ioskUlH/N4P5a5mlidjNd8QrxmSlfE3MMsISu8Kz0=; b=eNFTt187OoSsnTqlcHeg3my1D9NGh5EPh/tsk6+YZhWB9pkTJGiGZl6vqBTPYnm9dE FAMEa+kXhbCZY0w9N7UMSMqe6os868GbjBtBPr4H0oe+bbo6KN2U8GNtcOZqWSP0mgUx VznWTfyu+Z/zevz6hhMalFaVyfb6ihXey7ttvMWkZ3ZjQ/AyhK6xv0hgLXI9ndi8Wh1y y/5wTiIOBrkjfIvFO0v4xq3EExvuA8u0D1a/8kYiBtdGJd7wP4EEaGYctUL2tymc/Ljv L0XtdrgDY1k0ADkg2Aq53DR6DsehZ+4UQ29tzMD+Kzm8RRqWBOxfxvrLZfaDdLh46A+u blfQ== X-Gm-Message-State: AHYfb5iY224g4XSXw5iCgF+SyEYJv8vl4CdMprqevoGfbbDqb7oCBgGG yCtcD5xtgJiHHA== X-Received: by 10.99.152.9 with SMTP id q9mr13260405pgd.148.1503206790987; Sat, 19 Aug 2017 22:26:30 -0700 (PDT) Received: from localhost ([114.244.64.8]) by smtp.gmail.com with ESMTPSA id q89sm18004108pfd.156.2017.08.19.22.26.29 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 19 Aug 2017 22:26:30 -0700 (PDT) From: Peng Donglin To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Date: Sun, 20 Aug 2017 13:26:25 +0800 Message-Id: <1503206785-15638-1-git-send-email-dolinux.peng@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Peng Donglin Subject: [alsa-devel] [PATCH 07/12] ASoC: mxs-sgtl5000: Remove unnecessary function call X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP First of all,the address of pdev->dev is assigned to card->dev,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin --- sound/soc/mxs/mxs-sgtl5000.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/mxs/mxs-sgtl5000.c b/sound/soc/mxs/mxs-sgtl5000.c index a96276e..2ed3240 100644 --- a/sound/soc/mxs/mxs-sgtl5000.c +++ b/sound/soc/mxs/mxs-sgtl5000.c @@ -140,7 +140,6 @@ static int mxs_sgtl5000_probe(struct platform_device *pdev) } card->dev = &pdev->dev; - platform_set_drvdata(pdev, card); ret = devm_snd_soc_register_card(&pdev->dev, card); if (ret) {