From patchwork Sun Aug 20 05:43:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donglin Peng X-Patchwork-Id: 9910943 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E2E73602A0 for ; Sun, 20 Aug 2017 05:44:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C7E23286F9 for ; Sun, 20 Aug 2017 05:44:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A96CF28724; Sun, 20 Aug 2017 05:44:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 48F79286F9 for ; Sun, 20 Aug 2017 05:44:07 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id F3A3B267394; Sun, 20 Aug 2017 07:44:05 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5A483267396; Sun, 20 Aug 2017 07:44:05 +0200 (CEST) Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by alsa0.perex.cz (Postfix) with ESMTP id 4F367266BCF for ; Sun, 20 Aug 2017 07:44:02 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id w127so34844pfd.1 for ; Sat, 19 Aug 2017 22:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=RPR3kxk6mgc7tImYWLw/gDCUWnUDvw+Wqr3DY6fz0rY=; b=gSJXWvlC2PDEfdUMSSvbY3a9YRoAI5ebgqjJYOwFNx+TOcyPsigiNNLtlF+DvdkpgY YLMU5JNhqxGkNwDdi8PcCaVJq6C2SdWQHo7QWNG2nr1WBBtkfMd7yWXTWpcXLU06si48 bCwRKWoxlIhJgQpdrLU3IAjXyVqcrSM0/TLk2hDUuD/LgfE9+LIQsIJ4eTgcAgUIIlUP n/9h/QvMJ0qmQhI9iuUFr4QhGyWtKovloU7+y02tF68ZJlDvw9pg1yxPFvfFuKedLj6O 2VATWWEoZeesE8KEevzD2qjIJPvHSQL1dZKiaTz31VQU5tiN9KLgASrYMiY9vHgX8qpr merQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RPR3kxk6mgc7tImYWLw/gDCUWnUDvw+Wqr3DY6fz0rY=; b=XZNXkRdTgogJ+QwZQYPLPevnr70p4yeRAuK3F1Ol9pf7aAiQ+eo1ebdn/LzCYHrU3C wU8E6JygKW4X/SwdZIUbkG2FK5wK91n8ZCNwgN/yCm/cuwKHvqAI5RL4r99MaIDqtcxw 7LH7h65rRpywtCnaJ4K+jH2kLvJvCSFf5WiigplwQwxWkpzh8oFeFTmS7rJ9CR6hKZ+/ 9/lCMUnsf5ThsunrsXWpDU7pUEkcRgO4vYwh+xhqYfIQPdoR410yl//a1yDdVp/jylMO Hdx7QaL9Wk+B+kwrrlTEaN/bmiB6CgO0ksfVgST2O7au8z8a40FJbbSwAkAjBdgSmEfG BLCA== X-Gm-Message-State: AHYfb5jOeZJostPwzyds+zHUpOJMOUHTV9xPIEETL7ENrjK+pKIYnROS rxsDOM/1E3xCPg== X-Received: by 10.84.217.132 with SMTP id p4mr7624341pli.297.1503207841964; Sat, 19 Aug 2017 22:44:01 -0700 (PDT) Received: from localhost ([114.244.77.68]) by smtp.gmail.com with ESMTPSA id a63sm16937337pfc.165.2017.08.19.22.44.00 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 19 Aug 2017 22:44:01 -0700 (PDT) From: Peng Donglin To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, plai@codeaurora.org, bgoswami@codeaurora.org Date: Sun, 20 Aug 2017 13:43:57 +0800 Message-Id: <1503207837-16310-1-git-send-email-dolinux.peng@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Peng Donglin Subject: [alsa-devel] [PATCH 08/12] ASoC: qcom: Remove useless function call X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The function platform_set_drvdata(pdev, data) copies the value of the variable data to pdev->dev.driver_data,but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will override it, so i think that the former copy operation is useless and can be removed. Signed-off-by: Peng Donglin Acked-by: Banajit Goswami --- sound/soc/qcom/apq8016_sbc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c index d084d74..5292591 100644 --- a/sound/soc/qcom/apq8016_sbc.c +++ b/sound/soc/qcom/apq8016_sbc.c @@ -191,7 +191,6 @@ static int apq8016_sbc_platform_probe(struct platform_device *pdev) if (IS_ERR(data->spkr_iomux)) return PTR_ERR(data->spkr_iomux); - platform_set_drvdata(pdev, data); snd_soc_card_set_drvdata(card, data); return devm_snd_soc_register_card(&pdev->dev, card);