| Message ID | 1503207898-16378-1-git-send-email-dolinux.peng@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3bb2991c1d4d487323fde7b5b63985798c91a03f |
| Headers | show |
On Sun, Aug 20, 2017 at 01:44:58PM +0800, Peng Donglin wrote: > First of all,the address of pdev->dev is assigned to card->dev,then > the function platform_set_drvdata copies the value the variable card > to pdev->dev.driver_data, but when calling snd_soc_register_card,the > function dev_set_drvdata(card->dev, card) will also do the same copy > operation,so i think that the former copy operation can be removed. > > Signed-off-by: Peng Donglin <dolinux.peng@gmail.com> Acked-by: Banajit Goswami <bgoswami@codeaurora.org> > --- > sound/soc/qcom/storm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c > index c5207af..a9fa972 100644 > --- a/sound/soc/qcom/storm.c > +++ b/sound/soc/qcom/storm.c > @@ -99,7 +99,6 @@ static int storm_platform_probe(struct platform_device *pdev) > return -ENOMEM; > > card->dev = &pdev->dev; > - platform_set_drvdata(pdev, card); > > ret = snd_soc_of_parse_card_name(card, "qcom,model"); > if (ret) { > -- > 1.9.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c index c5207af..a9fa972 100644 --- a/sound/soc/qcom/storm.c +++ b/sound/soc/qcom/storm.c @@ -99,7 +99,6 @@ static int storm_platform_probe(struct platform_device *pdev) return -ENOMEM; card->dev = &pdev->dev; - platform_set_drvdata(pdev, card); ret = snd_soc_of_parse_card_name(card, "qcom,model"); if (ret) {
First of all,the address of pdev->dev is assigned to card->dev,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin <dolinux.peng@gmail.com> --- sound/soc/qcom/storm.c | 1 - 1 file changed, 1 deletion(-)