From patchwork Sun Aug 20 05:44:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donglin Peng X-Patchwork-Id: 9910947 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1384D602A0 for ; Sun, 20 Aug 2017 05:45:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 009C928871 for ; Sun, 20 Aug 2017 05:45:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E68022888B; Sun, 20 Aug 2017 05:45:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3AE1828871 for ; Sun, 20 Aug 2017 05:45:09 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 1E74B2673B9; Sun, 20 Aug 2017 07:45:08 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5A3EC2673BA; Sun, 20 Aug 2017 07:45:07 +0200 (CEST) Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by alsa0.perex.cz (Postfix) with ESMTP id 8738E266BCF for ; Sun, 20 Aug 2017 07:45:05 +0200 (CEST) Received: by mail-pg0-f68.google.com with SMTP id 83so19566421pgb.4 for ; Sat, 19 Aug 2017 22:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zwCOGTcdQdg8ydjx8/KuISvLdcitQmjdVvlVri6uyu0=; b=DOaxALmSScxXBnN620ZLT9kAeVwIdlpnqAskdnJYdkx8dEYhx3AIc356p5XQ95+e04 8TPE1mfViTY8dJBNvTQ+HdjOLmyjBd1xKA8pfwRBKuOBpp/zNv/2wHVLy7AkK2ArmDsR NkYwarOEAziFpd4Spixq6R/KxfaWmK/dbrlwM3u1B+y5zAmRr/RBR1oYFQ+xDMs6hvRu bGY9w5r8A6t9enpMKH3rTcevXR9Y6GFrUqZwhecvnkiq3SuvmjNZBEKzmDYePhg22OUG IcE64ZdVMzCTnEDZ9hBlFcWjv6IP91c3nV91/j3XiLNLsGk6k+rfCv6o8RIRH2yCjfuG +jUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zwCOGTcdQdg8ydjx8/KuISvLdcitQmjdVvlVri6uyu0=; b=XGucD5SdXGK1TKRU/9Fx8VsS8TC9GqiMHprINoJ/3Cid+Zr+aFAtWkHiq4yR2N56h7 /zK2EeW2AdlcciZKW8bZmuY6V5ZjPgruJwp3JbYedOVWIad2N6DgaQczZS2UIaR1yKHg GdZtzxaIuOJOT/HZfaZNL5er8QCuzcUOtrTyo2fUKppK6ZyO41upPobqmlDqWwpRm+w0 r+ZwQMNaAd1W0C8tH1NS7B0ccC3lG4YmJkC0+bxTozR2b9npCq5oiTm5yjYfp2icdCFv bOwClCBZhrFTTIU/2m0eyxzu37KSLVZscUUrotJ7UpkFonQuolEGBtMGx/YcuteBe/m2 Myhw== X-Gm-Message-State: AHYfb5jUyQ1Qag6S/uLkV8XRD21ukWT7/9dkIrv/gXOdSHKr2qO/yYzU jEsWNaZrMgfecw== X-Received: by 10.84.232.134 with SMTP id i6mr425833plk.432.1503207904404; Sat, 19 Aug 2017 22:45:04 -0700 (PDT) Received: from localhost ([123.123.129.103]) by smtp.gmail.com with ESMTPSA id i133sm19540257pgc.0.2017.08.19.22.45.03 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 19 Aug 2017 22:45:03 -0700 (PDT) From: Peng Donglin To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, plai@codeaurora.org, bgoswami@codeaurora.org Date: Sun, 20 Aug 2017 13:44:58 +0800 Message-Id: <1503207898-16378-1-git-send-email-dolinux.peng@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Peng Donglin Subject: [alsa-devel] [PATCH 09/12] ASoC: qcom: Remove unnecessary function call X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP First of all,the address of pdev->dev is assigned to card->dev,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin Acked-by: Banajit Goswami --- sound/soc/qcom/storm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c index c5207af..a9fa972 100644 --- a/sound/soc/qcom/storm.c +++ b/sound/soc/qcom/storm.c @@ -99,7 +99,6 @@ static int storm_platform_probe(struct platform_device *pdev) return -ENOMEM; card->dev = &pdev->dev; - platform_set_drvdata(pdev, card); ret = snd_soc_of_parse_card_name(card, "qcom,model"); if (ret) {