From patchwork Sun Aug 20 06:01:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donglin Peng X-Patchwork-Id: 9910959 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2E83260382 for ; Sun, 20 Aug 2017 06:01:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1CAEB288CE for ; Sun, 20 Aug 2017 06:01:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 11BE9288D2; Sun, 20 Aug 2017 06:01:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6B405288CE for ; Sun, 20 Aug 2017 06:01:22 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id D4DA92673C7; Sun, 20 Aug 2017 08:01:20 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4635F2673C8; Sun, 20 Aug 2017 08:01:20 +0200 (CEST) Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by alsa0.perex.cz (Postfix) with ESMTP id 85188266BCF for ; Sun, 20 Aug 2017 08:01:16 +0200 (CEST) Received: by mail-pg0-f65.google.com with SMTP id 83so19585252pgb.4 for ; Sat, 19 Aug 2017 23:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=tm2tc9uKzVh4Kq4ZPrcBFEmBCkVNFnYnj/AbyiNoXo4=; b=ryD4URz0Xjs9yy2RCrR3qh/IQTMu7c5yqADWf6hWjaYqQPNTwlVYpBG7MfUSpYriMI 2xULJo4Tgdr59PT1M3PXtLKT5+HA208NdhYiuDGcveJ0vTi5kt/91KryhV62eeNw9lqg yHdy5GQYL1DFl6UULwvB3SJRdASQmcR/7zqFzO9gW7wVEsu2gHV5hl55gr5xXe767ClJ K8N8XgdustyRXR67bxZ/wN1UBV5XmOVQO2bH4nebwzeMUZWKBEs37XzmVU+eDEDHmO1d GEInQvCT4AoSWHOLvbx/Lp+2BNmeGyPqkuP7tT60H8zqxxdG0tSNk8gcO417kqLgo5d1 lJHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tm2tc9uKzVh4Kq4ZPrcBFEmBCkVNFnYnj/AbyiNoXo4=; b=WdovFqfMaEKU1bLzyK43/b/1o9RxtOKcM1JLd2MscPI0M3RkL23X8spqBiVWoRwbEg d2QmLYHLksGU6GywUMeWdhqRwUcFZo3qqkOJuUDx9783HeS1UUkPYWVZVjAW39EFhu5l OrvN3Zd6BCqMXWm+YxfDyJnqQrO/sNP9VBM0SM/4GC/ZdKdTVVA9oc+7cJG4edVtp5LD mCdh3BTtKQfulZoyAXg6YLu4OPwW9zyq+hhh8ZdQv0JMXhg8zvURWfjt4jo/qj978zxe h4GhY6RupX8i63JNEsQbVbFGePiFn8J2l40i7XkFvuT4oN+Ir2robG5En9M8W0xvbMXS 1hEg== X-Gm-Message-State: AHYfb5gSgmXD5yzN0fV05XZ9hM5ObcYaohQUe87csY0cN9RGLHv8b016 ibsxhXn7hw6OIQ== X-Received: by 10.84.128.69 with SMTP id 63mr14828951pla.54.1503208874955; Sat, 19 Aug 2017 23:01:14 -0700 (PDT) Received: from localhost ([123.112.80.243]) by smtp.gmail.com with ESMTPSA id s67sm15385915pgb.13.2017.08.19.23.01.13 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 19 Aug 2017 23:01:14 -0700 (PDT) From: Peng Donglin To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Date: Sun, 20 Aug 2017 14:01:10 +0800 Message-Id: <1503208870-4313-1-git-send-email-dolinux.peng@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Peng Donglin Subject: [alsa-devel] [PATCH 12/12] ASoC: ux500: Remove unnecessary function call X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP First of all,the address of pdev->dev is assigned to mop500_card.dev, then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data,but when calling snd_soc_register_card, the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin --- sound/soc/ux500/mop500.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/ux500/mop500.c b/sound/soc/ux500/mop500.c index ba9fc09..070a688 100644 --- a/sound/soc/ux500/mop500.c +++ b/sound/soc/ux500/mop500.c @@ -115,7 +115,6 @@ static int mop500_probe(struct platform_device *pdev) dev_dbg(&pdev->dev, "%s: Card %s: Set platform drvdata.\n", __func__, mop500_card.name); - platform_set_drvdata(pdev, &mop500_card); snd_soc_card_set_drvdata(&mop500_card, NULL);