From patchwork Wed Aug 23 01:51:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rini X-Patchwork-Id: 9916459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 93047603F9 for ; Wed, 23 Aug 2017 01:51:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8421A2892A for ; Wed, 23 Aug 2017 01:51:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 78ED228955; Wed, 23 Aug 2017 01:51:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A73A2892A for ; Wed, 23 Aug 2017 01:51:47 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 62F77266C72; Wed, 23 Aug 2017 03:51:45 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id BC5F9266CFE; Wed, 23 Aug 2017 03:51:43 +0200 (CEST) Received: from mail-yw0-f196.google.com (mail-yw0-f196.google.com [209.85.161.196]) by alsa0.perex.cz (Postfix) with ESMTP id 792C2266834 for ; Wed, 23 Aug 2017 03:51:39 +0200 (CEST) Received: by mail-yw0-f196.google.com with SMTP id y64so244886ywf.1 for ; Tue, 22 Aug 2017 18:51:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OQ/J5/FUkNFWNTmhbzYChLNz1LdCGuU43O42EQroGzk=; b=dPOsKjOSWvfxinGJ8r2lU+XaaMPfL7cTU5RaB0csOOpal47o6FSaabhSKPyPM8CloC wtzr8VRFwhIV+djqNFUFndaV+4s6nRTpEhYUN78im0aErRFLHTrqakl37d6cxs7M4qFj kWeGFqLKLJH4FNZZLU1TimRaRf6TNNe6Y3xTENl2/sB1owwHZsMYmzZYQGx4CeWfqS6G DnK2kjUshQhLYJMlXw6tT4uCHNWoqvBYBCV+lcqkkFsZJVmeLUpAKCQUMm3nf1KzprKU 8UDXwQ5Vv1DMdryyo8n6bmu4B6XM/u/7hJaSJSD7U4D8/FSJRSwfzQPYPw7KfEjp/pUY XO9g== X-Gm-Message-State: AHYfb5iHC7nRyuA6iktI88e+5GFqrLRMv2bxubb5CCZr+YR7KqX7Ysm/ /6lFT95C1ceTEQ== X-Received: by 10.37.105.131 with SMTP id e125mr874110ybc.277.1503453098694; Tue, 22 Aug 2017 18:51:38 -0700 (PDT) Received: from localhost.localdomain (cpe-174-106-0-58.ec.res.rr.com. [174.106.0.58]) by smtp.gmail.com with ESMTPSA id n189sm157470ywe.66.2017.08.22.18.51.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Aug 2017 18:51:38 -0700 (PDT) From: Tom Rini To: linux-kernel@vger.kernel.org Date: Tue, 22 Aug 2017 21:51:46 -0400 Message-Id: <1503453106-5564-1-git-send-email-trini@konsulko.com> X-Mailer: git-send-email 1.9.1 Cc: Oder Chiou , alsa-devel@alsa-project.org, Andy Shevchenko , Takashi Iwai , Liam Girdwood , Mark Brown , Bard Liao , Linus Torvalds Subject: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Not all devices with ACPI and this combination of sound devices will have the required information provided via ACPI. Reintroduce the I2C device ID to restore sound functionality on on the Chromebook 'Samus' model. Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI enumeration") Cc: Bard Liao Cc: Oder Chiou Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-devel@alsa-project.org CC: linux-kernel@vger.kernel.org Cc: Andy Shevchenko Cc: Mark Brown Cc: Linus Torvalds Signed-off-by: Tom Rini --- This is a regression from v4.12 on my laptop (a Chromebook 'Samus' that's not running ChromeOS). My fault for getting out of the habit of trying -rc1 when it comes out and not spotting this sooner. I'm not 100% sure if this fix is correct for all cases as I'm only able to test my hardware here, and this does fix my laptop. --- sound/soc/codecs/rt5677.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 36e530a36c82..6f629278d982 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5021,6 +5021,7 @@ static int rt5677_write(void *context, unsigned int reg, unsigned int val) static const struct i2c_device_id rt5677_i2c_id[] = { { "rt5677", RT5677 }, { "rt5676", RT5676 }, + { "RT5677CE:00", RT5677 }, { } }; MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id);