From patchwork Wed Dec 13 06:34:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolin Chen X-Patchwork-Id: 10109323 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 26090602C2 for ; Wed, 13 Dec 2017 06:37:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 224241FF40 for ; Wed, 13 Dec 2017 06:37:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 173F628D11; Wed, 13 Dec 2017 06:37:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 457E01FF40 for ; Wed, 13 Dec 2017 06:37:38 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id DE00226786A; Wed, 13 Dec 2017 07:35:49 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 2986B267823; Wed, 13 Dec 2017 07:35:48 +0100 (CET) Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by alsa0.perex.cz (Postfix) with ESMTP id 490CE26781D for ; Wed, 13 Dec 2017 07:35:41 +0100 (CET) Received: by mail-pf0-f196.google.com with SMTP id u25so934962pfg.5 for ; Tue, 12 Dec 2017 22:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wSZ0SdxJ+FbFvBG9pM2EPdwkSd8UP3u84Y0CHmc97LE=; b=l93HqF7o+oVT9YYssAH209YuwHtGaYKPNA3tHn6uNgCt8wwnUQ2A7tRYPMiK7Y3bCy Psa13J8QBDCdrw2KrCHp+4tWEp6Z0OrA6RfOf8cql6lcS+x6vfTOdYGpkmjy3Ze1M/9c zZb/Lj4vpuHGKOY+I3efbestMLBQ2/Em28dlRqa1OEDuvL7IW8AO9UqPjBOuiS4pdE1f SeIYKUgSJqITkEdrsBZpA9/M1LujIZVSJQXZCU80wVSZS7ia9TEs1UWGktV/VfoS20+J DxNS63reeWvxI5qz2lRYmgrkoQSE9ymy9ANgaxSJLd9ISv3mBzO6mwt5UsXAqqWaT2PF eTlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wSZ0SdxJ+FbFvBG9pM2EPdwkSd8UP3u84Y0CHmc97LE=; b=Ud1sWkqb2FTunJhw8D+N3hWHfSUJsYhe1eWrXasQx6OHk6jZVh7NBoygGFFf9K9PQk ekXOlJeCUQJeQKxBk6kzS1hM026QDsNSvUeyaHOkHnDtLxwDMKNLbGApawgiZWdLyOuT f7LBYGKUk1ElcQiSUtv2W7aAh69hzKv7OzsNFwgdQkZA9LnazNKkerXPE1cradF1p+HC 9phKbQMBGlnQbkFdTC7P4Y/ZftFzcYwjA3nFt6fA+63nSORWSIvQ9jXJF8xuM8vVF26o 2rH6a6ZZjHm6w2+/LOEe8dacOruO5nyRH3bgt3+ljENzLpvtAZtYruXtGPwgaBu/dtRw NHHg== X-Gm-Message-State: AKGB3mKU1In0be/wkUR6Z+fSBBhEQTFjSuLUYhTENAqdclAp2UkmcIbh azeB6LXuR5j77W2eNXU5V60= X-Google-Smtp-Source: ACJfBovTqlcUYzRlXOO2yhcBmQcLE+l4AV032QmaQvQgBv75JD8zUo6dodefO/sFWzfr99O64q915Q== X-Received: by 10.101.65.129 with SMTP id a1mr4410215pgq.203.1513146938773; Tue, 12 Dec 2017 22:35:38 -0800 (PST) Received: from Asurada-CZ80.localdomain (c-73-231-2-134.hsd1.ca.comcast.net. [73.231.2.134]) by smtp.gmail.com with ESMTPSA id m63sm1574900pfj.80.2017.12.12.22.35.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Dec 2017 22:35:38 -0800 (PST) From: Nicolin Chen To: broonie@kernel.org Date: Tue, 12 Dec 2017 22:34:29 -0800 Message-Id: <1513146874-25476-7-git-send-email-nicoleotsuka@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1513146874-25476-1-git-send-email-nicoleotsuka@gmail.com> References: <1513146874-25476-1-git-send-email-nicoleotsuka@gmail.com> Cc: alsa-devel@alsa-project.org, kernel@pengutronix.de, lgirdwood@gmail.com, timur@tabi.org, caleb@crome.org, linux-kernel@vger.kernel.org, arnaud.mouiche@invoxia.com, lukma@denx.de, fabio.estevam@nxp.com, mail@maciej.szmigiero.name, linuxppc-dev@lists.ozlabs.org Subject: [alsa-devel] [PATCH v2 06/11] ASoC: fsl_ssi: Refine printk outputs X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This patches unifies the error message in the "failed to xxxx" format. It also reduces the length of one line and adds spaces to an operator. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 9a3db08..d3bb662 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -701,7 +701,7 @@ static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream, * never greater than 1/5 IPG clock rate */ if (freq * 5 > clk_get_rate(ssi->clk)) { - dev_err(cpu_dai->dev, "bitclk > ipgclk/5\n"); + dev_err(cpu_dai->dev, "bitclk > ipgclk / 5\n"); return -EINVAL; } @@ -868,7 +868,7 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev, ssi->dai_fmt = fmt; if (fsl_ssi_is_i2s_master(ssi) && IS_ERR(ssi->baudclk)) { - dev_err(dev, "baudclk is missing which is necessary for master mode\n"); + dev_err(dev, "missing baudclk for master mode\n"); return -EINVAL; } @@ -1284,7 +1284,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev, ssi->clk = devm_clk_get(dev, NULL); if (IS_ERR(ssi->clk)) { ret = PTR_ERR(ssi->clk); - dev_err(dev, "could not get clock: %d\n", ret); + dev_err(dev, "failed to get clock: %d\n", ret); return ret; } @@ -1300,7 +1300,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev, /* Do not error out for slave cases that live without a baud clock */ ssi->baudclk = devm_clk_get(dev, "baud"); if (IS_ERR(ssi->baudclk)) - dev_dbg(dev, "could not get baud clock: %ld\n", + dev_dbg(dev, "failed to get baud clock: %ld\n", PTR_ERR(ssi->baudclk)); ssi->dma_params_tx.maxburst = ssi->dma_maxburst; @@ -1421,7 +1421,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ®config); } if (IS_ERR(ssi->regs)) { - dev_err(dev, "Failed to init register map\n"); + dev_err(dev, "failed to init register map\n"); return PTR_ERR(ssi->regs); } @@ -1480,7 +1480,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) mutex_init(&ssi->ac97_reg_lock); ret = snd_soc_set_ac97_ops_of_reset(&fsl_ssi_ac97_ops, pdev); if (ret) { - dev_err(dev, "could not set AC'97 ops\n"); + dev_err(dev, "failed to set AC'97 ops\n"); goto error_ac97_ops; } } @@ -1496,7 +1496,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ret = devm_request_irq(dev, ssi->irq, fsl_ssi_isr, 0, dev_name(dev), ssi); if (ret < 0) { - dev_err(dev, "could not claim irq %u\n", ssi->irq); + dev_err(dev, "failed to claim irq %u\n", ssi->irq); goto error_asoc_register; } } @@ -1538,7 +1538,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ret = of_property_read_u32(np, "cell-index", &ssi_idx); if (ret) { - dev_err(dev, "cannot get SSI index property\n"); + dev_err(dev, "failed to get SSI index property\n"); goto error_sound_card; }